From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] MIPS: XBurst: fix compiler warnings in reset-jz4750.c
Date: Mon, 25 Jun 2012 14:16:51 +0200 [thread overview]
Message-ID: <20120625121651.GC14321@pengutronix.de> (raw)
In-Reply-To: <1340621891-4826-1-git-send-email-antonynpavlov@gmail.com>
On Mon, Jun 25, 2012 at 02:58:11PM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Squashed into the original commit causing the warnings.
Thanks
Sascha
> ---
> arch/mips/mach-xburst/reset-jz4750.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/mach-xburst/reset-jz4750.c b/arch/mips/mach-xburst/reset-jz4750.c
> index 4bda56c..765c033 100644
> --- a/arch/mips/mach-xburst/reset-jz4750.c
> +++ b/arch/mips/mach-xburst/reset-jz4750.c
> @@ -29,7 +29,7 @@
>
> #define JZ_EXTAL 24000000
>
> -static void jz4750d_halt(void)
> +static void __noreturn jz4750d_halt(void)
> {
> while (1) {
> __asm__(".set push;\n"
> @@ -65,10 +65,10 @@ void __noreturn poweroff()
> shutdown_barebox();
>
> do {
> - ctrl = readl(RTC_RCR);
> + ctrl = readl((u32 *)RTC_RCR);
> } while (!(ctrl & RTC_RCR_WRDY));
>
> - writel(RTC_HCR_PD, RTC_HCR);
> + writel(RTC_HCR_PD, (u32 *)RTC_HCR);
> jz4750d_halt();
> }
> EXPORT_SYMBOL(poweroff);
> --
> 1.7.10
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-06-25 12:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 10:58 Antony Pavlov
2012-06-25 12:16 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120625121651.GC14321@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox