mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: is errno supposed to be positive or negative?
Date: Wed, 27 Jun 2012 15:53:25 +0200	[thread overview]
Message-ID: <20120627135325.GO1623@pengutronix.de> (raw)
In-Reply-To: <20120627105915.GE18096@pengutronix.de>

On Wed, Jun 27, 2012 at 12:59:15PM +0200, Uwe Kleine-König wrote:
> On Wed, Jun 27, 2012 at 11:51:28AM +0200, Sascha Hauer wrote:
> > On Wed, Jun 27, 2012 at 11:35:51AM +0200, Uwe Kleine-König wrote:
> > > Hello,
> > > 
> > > Well, ok, errno is supposed to be zero, but in the rare cases where it's
> > > not, what is intended?
> > > 
> > > Assuming ESOMETHING is always positive, in userspace errno is
> > > positive, e.g. you test for errno == EBADF.
> > > 
> > > In barebox however most assignments use
> > > 
> > > 	errno = -ESOMETHING
> > > 
> > > but there are also some tests and assignments without minus. barebox'
> > > perror expects a negative errno which is also different from POSIX'
> > > perror. strerror uses positive semantics in both barebox and POSIX.
> > 
> > Your tree is not up to date.
> > 
> > see:
> > 
> > commit 6188685091c58c9772b990cf0ca6ac522f97a9d0
> > Author: Sascha Hauer <s.hauer@pengutronix.de>
> > Date:   Sun May 13 12:43:58 2012 +0200
> > 
> >     Make errno a positive value
> >     
> >     Normally errno contains a positive error value. A certain unnamed developer
> >     mixed this up while implementing U-Boot-v2. Also, normally errno is never
> >     set to zero by any library function. This patch fixes this.
> >     
> >     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> OK, you're right.
> 
> There is just:
> 
> 	$ git grep errno\ =\ -E origin/master
> 	origin/master:fs/ramfs.c:                       errno = -ENOENT;

Oops, this shouldn't be there at all. errno should be set in the
filesystem layer, not in the fs drivers.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2012-06-27 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-27  9:35 Uwe Kleine-König
2012-06-27  9:51 ` Sascha Hauer
2012-06-27 10:59   ` Uwe Kleine-König
2012-06-27 13:53     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120627135325.GO1623@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox