From: Sascha Hauer <s.hauer@pengutronix.de>
To: Christian Kapeller <christian.kapeller@cmotion.eu>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Fix compile error loady command, without loadb.
Date: Thu, 19 Jul 2012 16:36:45 +0200 [thread overview]
Message-ID: <20120719143645.GZ30009@pengutronix.de> (raw)
In-Reply-To: <1342698019-21374-1-git-send-email-christian.kapeller@cmotion.eu>
Hi Christian,
This is already fixed in -next.
On Thu, Jul 19, 2012 at 01:40:19PM +0200, Christian Kapeller wrote:
> The global variable ofd is needed by both loady and loadb.
btw please sign-off your patches.
Sascha
> ---
> commands/loadb.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/commands/loadb.c b/commands/loadb.c
> index 9a697dd..50f323e 100644
> --- a/commands/loadb.c
> +++ b/commands/loadb.c
> @@ -61,10 +61,10 @@
> #define untochar(x) ((int) (((x) - SPACE) & 0xff))
> #define DEF_FILE "image.bin"
>
> -#ifdef CONFIG_CMD_LOADB
> -
> static int ofd; /* output file descriptor */
>
> +#ifdef CONFIG_CMD_LOADB
> +
> /* Size of my buffer to write to o/p file */
> #define MAX_WRITE_BUFFER 4096 /* Write size to o/p file */
> static char *write_buffer; /* buffer for finalized data to write */
> --
> 1.7.5.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-07-19 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 11:40 Christian Kapeller
2012-07-19 14:36 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719143645.GZ30009@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=christian.kapeller@cmotion.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox