From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1StCsS-0004df-Ug for barebox@lists.infradead.org; Mon, 23 Jul 2012 07:16:31 +0000 Date: Mon, 23 Jul 2012 09:16:22 +0200 From: Sascha Hauer Message-ID: <20120723071622.GX30009@pengutronix.de> References: <20120723042052.GK22657@game.jcrosoft.org> <1343017563-27932-1-git-send-email-plagnioj@jcrosoft.com> <1343017563-27932-6-git-send-email-plagnioj@jcrosoft.com> <20120723063523.GV30009@pengutronix.de> <20120723064134.GO22657@game.jcrosoft.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120723064134.GO22657@game.jcrosoft.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 6/7] compressed: rename barebox target to zbarebox and zbarebox.bin To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Mon, Jul 23, 2012 at 08:41:34AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 08:35 Mon 23 Jul , Sascha Hauer wrote: > > On Mon, Jul 23, 2012 at 06:26:02AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > Today we link to whole barebox and rely on gcc to cleanup via it's garbage > > > collector. > > > Now we specify only what is needed and introduce a new directory with source > > > only related to the compressed target. > > > > > > Build it in arch//compressed > > > Rebuild all the needed object. > > > > > > Keep the previous target untouched. > > > This fix the modules support and allow custom flags for each file. > > > > > > Import string functions from linux 3.4 (arch/arm/boot/compressed/string.c) and > > > implement a dummy panic. > > > > This does not work on all targets having a lowlevel init: > > > > arch/arm/compressed/start.o: In function `reset': > > start.c:(.text_bare_init.text+0x28): undefined reference to `board_init_lowlevel' > > > > Why don't we simply do this: > > > > > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > > index 647c536..12869b3 100644 > > --- a/arch/arm/Makefile > > +++ b/arch/arm/Makefile > > @@ -150,11 +150,9 @@ TEXT_BASE = $(CONFIG_TEXT_BASE) > > > > CPPFLAGS += -DTEXT_BASE=$(TEXT_BASE) > > > > -ifndef CONFIG_MODULES > > # Add cleanup flags > > CPPFLAGS += -fdata-sections -ffunction-sections > > LDFLAGS_barebox += -static --gc-sections > > -endif > you can not do this as this break modules Does it really? I see this goes back to: commit 8a03bff03ebf36b7460e6ec43259bc8b40731ece Author: Sascha Hauer Date: Thu Jul 3 10:30:44 2008 +0200 [arm] Add cleanup flags only when modules are disabled. Otherwise we remove functions from the binary which are needed for modules I can't see though why this should happen. What is needed for modules is defined by EXPORT_SYMBOL. Unfortunately modules are quite broken atm for me anyway, so I can't test. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox