mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM i.MX53: notify clocksource about changing clock
@ 2012-07-24 13:50 Wjatscheslaw Stoljarski (Slawa)
  2012-07-25  6:42 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Wjatscheslaw Stoljarski (Slawa) @ 2012-07-24 13:50 UTC (permalink / raw)
  To: barebox

This fix a clock inaccuracy in get_time_ns (used by sleep, time, etc).

At i.MX53 power-on GPT clock is typically 55500000 Hz, and it will be used
to calc the clock multiplier. After call imx53_init_lowlevel() GPT clock 
will
changed (e.g. to 66666666 Hz), but multiplier not. To fix this behavior call
clock_notifier_call_chain() after changing clock in imx53_init_lowlevel().

Signed-off-by: Wjatscheslaw Stoljarski 
<wjatscheslaw.stoljarski@kiwigrid.com>
---
  arch/arm/mach-imx/imx53.c |    3 +++
  1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-imx/imx53.c b/arch/arm/mach-imx/imx53.c
index e20b60a..3359819 100644
--- a/arch/arm/mach-imx/imx53.c
+++ b/arch/arm/mach-imx/imx53.c
@@ -18,6 +18,7 @@
  #include <init.h>
  #include <common.h>
  #include <io.h>
+#include <notifier.h>
  #include <sizes.h>
  #include <mach/imx5.h>
  #include <mach/imx-regs.h>
@@ -211,4 +212,6 @@ void imx53_init_lowlevel(unsigned int cpufreq_mhz)
  	writel(0xffffffff, ccm + MX53_CCM_CCGR7);
   	writel(0, ccm + MX5_CCM_CCDR);
+
+	clock_notifier_call_chain();
  }
-- 
1.7.9.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM i.MX53: notify clocksource about changing clock
  2012-07-24 13:50 [PATCH] ARM i.MX53: notify clocksource about changing clock Wjatscheslaw Stoljarski (Slawa)
@ 2012-07-25  6:42 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2012-07-25  6:42 UTC (permalink / raw)
  To: Wjatscheslaw Stoljarski (Slawa); +Cc: barebox

On Tue, Jul 24, 2012 at 03:50:08PM +0200, Wjatscheslaw Stoljarski (Slawa) wrote:
> This fix a clock inaccuracy in get_time_ns (used by sleep, time, etc).
> 
> At i.MX53 power-on GPT clock is typically 55500000 Hz, and it will be used
> to calc the clock multiplier. After call imx53_init_lowlevel() GPT
> clock will
> changed (e.g. to 66666666 Hz), but multiplier not. To fix this behavior call
> clock_notifier_call_chain() after changing clock in imx53_init_lowlevel().
> 
> Signed-off-by: Wjatscheslaw Stoljarski
> <wjatscheslaw.stoljarski@kiwigrid.com>

Your patch has some formatting problems, for example the line above is
broken into two. Please consider using git send-email next time.

Applied manually. Thanks

 Sascha

> ---
>  arch/arm/mach-imx/imx53.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/imx53.c b/arch/arm/mach-imx/imx53.c
> index e20b60a..3359819 100644
> --- a/arch/arm/mach-imx/imx53.c
> +++ b/arch/arm/mach-imx/imx53.c
> @@ -18,6 +18,7 @@
>  #include <init.h>
>  #include <common.h>
>  #include <io.h>
> +#include <notifier.h>
>  #include <sizes.h>
>  #include <mach/imx5.h>
>  #include <mach/imx-regs.h>
> @@ -211,4 +212,6 @@ void imx53_init_lowlevel(unsigned int cpufreq_mhz)
>  	writel(0xffffffff, ccm + MX53_CCM_CCGR7);
>   	writel(0, ccm + MX5_CCM_CCDR);
> +
> +	clock_notifier_call_chain();
>  }
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-07-25  6:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-24 13:50 [PATCH] ARM i.MX53: notify clocksource about changing clock Wjatscheslaw Stoljarski (Slawa)
2012-07-25  6:42 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox