From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] fs/mount: add autodetection type support
Date: Mon, 13 Aug 2012 09:30:01 +0200 [thread overview]
Message-ID: <20120813073001.GN6271@game.jcrosoft.org> (raw)
In-Reply-To: <20120813070850.GM25520@pengutronix.de>
On 09:08 Mon 13 Aug , Uwe Kleine-König wrote:
> Hello,
>
> On Sun, Aug 12, 2012 at 01:49:36PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > +static const char * detect_fs(const char *filename)
> > +{
> > + enum filetype type = file_name_detect_type(filename);
> > + struct driver_d *drv;
> > + struct fs_driver_d *fdrv;
> > +
> > + if (type == filetype_unknown)
> > + return NULL;
> > +
> > + for_each_driver(drv) {
> > + fdrv = drv_to_fs_driver(drv);
> > +
> > + if (drv->bus != &fs_bus)
> > + continue;
> > +
> > + if(type == fdrv->type)
> > + return drv->name;
> fdrv could be local to this loop only.
I never declare a var in a loop
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-08-13 7:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-12 11:46 [PATCH 0/4] fs/mount: add autodetection support Jean-Christophe PLAGNIOL-VILLARD
2012-08-12 11:49 ` [PATCH 1/4] fs/mount: add autodetection type support Jean-Christophe PLAGNIOL-VILLARD
2012-08-12 11:49 ` [PATCH 2/4] filetype: add fat filesystem support Jean-Christophe PLAGNIOL-VILLARD
2012-08-12 11:49 ` [PATCH 3/4] fs/fat: add filetype Jean-Christophe PLAGNIOL-VILLARD
2012-08-12 11:49 ` [PATCH 4/4] command/mount: add autodetection support Jean-Christophe PLAGNIOL-VILLARD
2012-08-12 12:43 ` Sascha Hauer
2012-08-12 12:46 ` [PATCH 1/4] fs/mount: add autodetection type support Sascha Hauer
2012-08-13 7:08 ` Uwe Kleine-König
2012-08-13 7:30 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-08-13 8:16 ` Uwe Kleine-König
2012-08-13 10:56 ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-12 18:05 [PATCH 0/4 v2] fs/mount: add autodetection support Jean-Christophe PLAGNIOL-VILLARD
2012-08-12 18:10 ` [PATCH 1/4] fs/mount: add autodetection type support Jean-Christophe PLAGNIOL-VILLARD
2012-08-13 18:49 ` Sascha Hauer
2012-08-15 7:25 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120813073001.GN6271@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox