From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 5.mo2.mail-out.ovh.net ([87.98.181.248] helo=mo2.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T6ak2-0000dj-7r for barebox@lists.infradead.org; Wed, 29 Aug 2012 05:23:03 +0000 Received: from mail21.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo2.mail-out.ovh.net (Postfix) with SMTP id AB460DC26F2 for ; Wed, 29 Aug 2012 07:28:08 +0200 (CEST) Date: Wed, 29 Aug 2012 07:23:16 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20120829052316.GC18708@game.jcrosoft.org> References: <20120824044613.GI6271@game.jcrosoft.org> <1345783818-28784-1-git-send-email-plagnioj@jcrosoft.com> <1345783818-28784-15-git-send-email-plagnioj@jcrosoft.com> <20120827141206.GK26594@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120827141206.GK26594@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 15/18] evnfs: introduce major and minor To: Sascha Hauer Cc: barebox@lists.infradead.org On 16:12 Mon 27 Aug , Sascha Hauer wrote: > On Fri, Aug 24, 2012 at 06:50:15AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > they are store in the super block at byte 16th and 17th. > > > > set the verison at 0.1 > > Only this little comment makes clear that with major and minor you mean > a version. I first thought about device nodes... > > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > --- > > common/environment.c | 2 ++ > > include/envfs.h | 7 ++++++- > > 2 files changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/common/environment.c b/common/environment.c > > index 52ce0de..257f35f 100644 > > --- a/common/environment.c > > +++ b/common/environment.c > > @@ -125,6 +125,8 @@ int envfs_save(char *filename, char *dirname) > > > > super = (struct envfs_super *)buf; > > super->magic = ENVFS_32(ENVFS_MAGIC); > > + super->major = ENVFS_32(ENVFS_MAJOR); > > + super->minor = ENVFS_32(ENVFS_MINOR); > > major and minor are 8bit wide but you read 32? yep > > > super->size = ENVFS_32(size); > > > > /* second pass: copy files to buffer */ > > diff --git a/include/envfs.h b/include/envfs.h > > index ba976d6..c6df8c5 100644 > > --- a/include/envfs.h > > +++ b/include/envfs.h > > @@ -5,6 +5,9 @@ > > #include > > #endif > > > > +#define ENVFS_MAJOR 0 > > +#define ENVFS_MINOR 1 > > + > > #define ENVFS_MAGIC 0x798fba79 /* some random number */ > > #define ENVFS_INODE_MAGIC 0x67a8c78d > > #define ENVFS_END_MAGIC 0x6a87d6cd > > @@ -29,8 +32,10 @@ struct envfs_super { > > uint32_t priority; > > uint32_t crc; /* crc for the data */ > > uint32_t size; /* size of data */ > > + uint8_t major; /* major */ > > + uint8_t minor; /* minor */ > > + uint16_t future; /* reserved for future use */ > > uint32_t flags; /* feature flags */ > > - uint32_t future; /* reserved for future use */ > > Why do you move the position of the flags field in envfs_super? keep all non-use data together flags not used too Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox