mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] NAND Flash SMC timings update (nwe_pulse) for calao board based on AT91SAM9G20 SoC
@ 2012-08-28  6:40 gregory hermant
  2012-08-29  7:12 ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: gregory hermant @ 2012-08-28  6:40 UTC (permalink / raw)
  To: barebox

Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
---
 arch/arm/boards/tny-a926x/init.c |    2 +-
 arch/arm/boards/usb-a926x/init.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boards/tny-a926x/init.c b/arch/arm/boards/tny-a926x/init.c
index d58132a..5538a44 100644
--- a/arch/arm/boards/tny-a926x/init.c
+++ b/arch/arm/boards/tny-a926x/init.c
@@ -89,7 +89,7 @@ static struct sam9_smc_config tny_a9g20_nand_smc_config = {
 	.ncs_read_pulse		= 4,
 	.nrd_pulse		= 4,
 	.ncs_write_pulse	= 4,
-	.nwe_pulse		= 2,
+	.nwe_pulse		= 4,
 
 	.read_cycle		= 7,
 	.write_cycle		= 7,
diff --git a/arch/arm/boards/usb-a926x/init.c b/arch/arm/boards/usb-a926x/init.c
index 7e63876..00a215d 100644
--- a/arch/arm/boards/usb-a926x/init.c
+++ b/arch/arm/boards/usb-a926x/init.c
@@ -90,7 +90,7 @@ static struct sam9_smc_config usb_a9g20_nand_smc_config = {
 	.ncs_read_pulse		= 4,
 	.nrd_pulse		= 4,
 	.ncs_write_pulse	= 4,
-	.nwe_pulse		= 2,
+	.nwe_pulse		= 4,
 
 	.read_cycle		= 7,
 	.write_cycle		= 7,
-- 
1.5.6.3



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] NAND Flash SMC timings update (nwe_pulse) for calao board based on AT91SAM9G20 SoC
  2012-08-28  6:40 [PATCH] NAND Flash SMC timings update (nwe_pulse) for calao board based on AT91SAM9G20 SoC gregory hermant
@ 2012-08-29  7:12 ` Sascha Hauer
  2012-08-30  7:06   ` gregory hermant
  0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2012-08-29  7:12 UTC (permalink / raw)
  To: gregory hermant; +Cc: barebox

On Tue, Aug 28, 2012 at 08:40:57AM +0200, gregory hermant wrote:
> Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>

The commmit log is a bit sparse. It would be interesting if this is an
enhancement, fixes a problem, is needed on newer board revisions...

Sascha

> ---
>  arch/arm/boards/tny-a926x/init.c |    2 +-
>  arch/arm/boards/usb-a926x/init.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boards/tny-a926x/init.c b/arch/arm/boards/tny-a926x/init.c
> index d58132a..5538a44 100644
> --- a/arch/arm/boards/tny-a926x/init.c
> +++ b/arch/arm/boards/tny-a926x/init.c
> @@ -89,7 +89,7 @@ static struct sam9_smc_config tny_a9g20_nand_smc_config = {
>  	.ncs_read_pulse		= 4,
>  	.nrd_pulse		= 4,
>  	.ncs_write_pulse	= 4,
> -	.nwe_pulse		= 2,
> +	.nwe_pulse		= 4,
>  
>  	.read_cycle		= 7,
>  	.write_cycle		= 7,
> diff --git a/arch/arm/boards/usb-a926x/init.c b/arch/arm/boards/usb-a926x/init.c
> index 7e63876..00a215d 100644
> --- a/arch/arm/boards/usb-a926x/init.c
> +++ b/arch/arm/boards/usb-a926x/init.c
> @@ -90,7 +90,7 @@ static struct sam9_smc_config usb_a9g20_nand_smc_config = {
>  	.ncs_read_pulse		= 4,
>  	.nrd_pulse		= 4,
>  	.ncs_write_pulse	= 4,
> -	.nwe_pulse		= 2,
> +	.nwe_pulse		= 4,
>  
>  	.read_cycle		= 7,
>  	.write_cycle		= 7,
> -- 
> 1.5.6.3
> 
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] NAND Flash SMC timings update (nwe_pulse) for calao board based on AT91SAM9G20 SoC
  2012-08-29  7:12 ` Sascha Hauer
@ 2012-08-30  7:06   ` gregory hermant
  2012-08-31  7:35     ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: gregory hermant @ 2012-08-30  7:06 UTC (permalink / raw)
  To: barebox

Hello sascha,
It's just a typo.
gregory

Sascha Hauer wrote:
> On Tue, Aug 28, 2012 at 08:40:57AM +0200, gregory hermant wrote:
>> Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
> 
> The commmit log is a bit sparse. It would be interesting if this is an
> enhancement, fixes a problem, is needed on newer board revisions...
> 
> Sascha
> 
>> ---
>>  arch/arm/boards/tny-a926x/init.c |    2 +-
>>  arch/arm/boards/usb-a926x/init.c |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boards/tny-a926x/init.c b/arch/arm/boards/tny-a926x/init.c
>> index d58132a..5538a44 100644
>> --- a/arch/arm/boards/tny-a926x/init.c
>> +++ b/arch/arm/boards/tny-a926x/init.c
>> @@ -89,7 +89,7 @@ static struct sam9_smc_config tny_a9g20_nand_smc_config = {
>>  	.ncs_read_pulse		= 4,
>>  	.nrd_pulse		= 4,
>>  	.ncs_write_pulse	= 4,
>> -	.nwe_pulse		= 2,
>> +	.nwe_pulse		= 4,
>>  
>>  	.read_cycle		= 7,
>>  	.write_cycle		= 7,
>> diff --git a/arch/arm/boards/usb-a926x/init.c b/arch/arm/boards/usb-a926x/init.c
>> index 7e63876..00a215d 100644
>> --- a/arch/arm/boards/usb-a926x/init.c
>> +++ b/arch/arm/boards/usb-a926x/init.c
>> @@ -90,7 +90,7 @@ static struct sam9_smc_config usb_a9g20_nand_smc_config = {
>>  	.ncs_read_pulse		= 4,
>>  	.nrd_pulse		= 4,
>>  	.ncs_write_pulse	= 4,
>> -	.nwe_pulse		= 2,
>> +	.nwe_pulse		= 4,
>>  
>>  	.read_cycle		= 7,
>>  	.write_cycle		= 7,
>> -- 
>> 1.5.6.3
>>
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] NAND Flash SMC timings update (nwe_pulse) for calao board based on AT91SAM9G20 SoC
  2012-08-30  7:06   ` gregory hermant
@ 2012-08-31  7:35     ` Sascha Hauer
  0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2012-08-31  7:35 UTC (permalink / raw)
  To: gregory hermant; +Cc: barebox

On Thu, Aug 30, 2012 at 09:06:06AM +0200, gregory hermant wrote:
> Hello sascha,
> It's just a typo.
> gregory

Applied now, thanks

Sascha

> 
> Sascha Hauer wrote:
> > On Tue, Aug 28, 2012 at 08:40:57AM +0200, gregory hermant wrote:
> >> Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
> > 
> > The commmit log is a bit sparse. It would be interesting if this is an
> > enhancement, fixes a problem, is needed on newer board revisions...
> > 
> > Sascha
> > 
> >> ---
> >>  arch/arm/boards/tny-a926x/init.c |    2 +-
> >>  arch/arm/boards/usb-a926x/init.c |    2 +-
> >>  2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm/boards/tny-a926x/init.c b/arch/arm/boards/tny-a926x/init.c
> >> index d58132a..5538a44 100644
> >> --- a/arch/arm/boards/tny-a926x/init.c
> >> +++ b/arch/arm/boards/tny-a926x/init.c
> >> @@ -89,7 +89,7 @@ static struct sam9_smc_config tny_a9g20_nand_smc_config = {
> >>  	.ncs_read_pulse		= 4,
> >>  	.nrd_pulse		= 4,
> >>  	.ncs_write_pulse	= 4,
> >> -	.nwe_pulse		= 2,
> >> +	.nwe_pulse		= 4,
> >>  
> >>  	.read_cycle		= 7,
> >>  	.write_cycle		= 7,
> >> diff --git a/arch/arm/boards/usb-a926x/init.c b/arch/arm/boards/usb-a926x/init.c
> >> index 7e63876..00a215d 100644
> >> --- a/arch/arm/boards/usb-a926x/init.c
> >> +++ b/arch/arm/boards/usb-a926x/init.c
> >> @@ -90,7 +90,7 @@ static struct sam9_smc_config usb_a9g20_nand_smc_config = {
> >>  	.ncs_read_pulse		= 4,
> >>  	.nrd_pulse		= 4,
> >>  	.ncs_write_pulse	= 4,
> >> -	.nwe_pulse		= 2,
> >> +	.nwe_pulse		= 4,
> >>  
> >>  	.read_cycle		= 7,
> >>  	.write_cycle		= 7,
> >> -- 
> >> 1.5.6.3
> >>
> >>
> >>
> >> _______________________________________________
> >> barebox mailing list
> >> barebox@lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/barebox
> >>
> > 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-08-31  7:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-28  6:40 [PATCH] NAND Flash SMC timings update (nwe_pulse) for calao board based on AT91SAM9G20 SoC gregory hermant
2012-08-29  7:12 ` Sascha Hauer
2012-08-30  7:06   ` gregory hermant
2012-08-31  7:35     ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox