From: Sascha Hauer <s.hauer@pengutronix.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net: miidev: really wait for auto negotiation
Date: Mon, 3 Sep 2012 09:44:12 +0200 [thread overview]
Message-ID: <20120903074412.GZ26594@pengutronix.de> (raw)
In-Reply-To: <1346428837-20422-1-git-send-email-w.sang@pengutronix.de>
On Fri, Aug 31, 2012 at 06:00:37PM +0200, Wolfram Sang wrote:
> miidev_wait_aneg() polled the wrong bit, so link detection did fail on
> boards where the PHY had to come out of a powerdown mode.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Applied, thanks
Sascha
> ---
> drivers/net/miidev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/miidev.c b/drivers/net/miidev.c
> index b49944b..75b53e3 100644
> --- a/drivers/net/miidev.c
> +++ b/drivers/net/miidev.c
> @@ -116,7 +116,7 @@ int miidev_wait_aneg(struct mii_device *mdev)
> return -ETIMEDOUT;
> }
>
> - } while (!(status & BMSR_LSTATUS));
> + } while (!(status & BMSR_ANEGCOMPLETE));
>
> return 0;
> }
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-09-03 7:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 16:00 Wolfram Sang
2012-09-03 7:44 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903074412.GZ26594@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox