[PATCH] net: miidev: really wait for auto negotiation

[PATCH] net: miidev: really wait for auto negotiation

[Wolfram Sang]

miidev_wait_aneg() polled the wrong bit, so link detection did fail on
boards where the PHY had to come out of a powerdown mode.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---
 drivers/net/miidev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/miidev.c b/drivers/net/miidev.c
index b49944b..75b53e3 100644
--- a/drivers/net/miidev.c
+++ b/drivers/net/miidev.c
@@ -116,7 +116,7 @@ int miidev_wait_aneg(struct mii_device *mdev)
 			return -ETIMEDOUT;
 		}
 
-	} while (!(status & BMSR_LSTATUS));
+	} while (!(status & BMSR_ANEGCOMPLETE));
 
 	return 0;
 }
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] net: miidev: really wait for auto negotiation

[Sascha Hauer]

On Fri, Aug 31, 2012 at 06:00:37PM +0200, Wolfram Sang wrote:
> miidev_wait_aneg() polled the wrong bit, so link detection did fail on
> boards where the PHY had to come out of a powerdown mode.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>

Applied, thanks

Sascha

> ---
>  drivers/net/miidev.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/miidev.c b/drivers/net/miidev.c
> index b49944b..75b53e3 100644
> --- a/drivers/net/miidev.c
> +++ b/drivers/net/miidev.c
> @@ -116,7 +116,7 @@ int miidev_wait_aneg(struct mii_device *mdev)
>  			return -ETIMEDOUT;
>  		}
>  
> -	} while (!(status & BMSR_LSTATUS));
> +	} while (!(status & BMSR_ANEGCOMPLETE));
>  
>  	return 0;
>  }
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox