From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Jan Weitzel <J.Weitzel@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: Suspected ##SPAM## -:Re: [PATCH v4] xload: get barebox size from barebox_arm_head
Date: Wed, 5 Sep 2012 14:02:24 +0200 [thread overview]
Message-ID: <20120905120224.GD32603@game.jcrosoft.org> (raw)
In-Reply-To: <1346845030.3625.16.camel@lws-weitzel>
On 13:37 Wed 05 Sep , Jan Weitzel wrote:
> Am Mittwoch, den 05.09.2012, 12:34 +0200 schrieb Jean-Christophe
> PLAGNIOL-VILLARD:
> > On 10:22 Wed 05 Sep , Jan Weitzel wrote:
> > > Add functions to read the barebox_arm_head, check barebox magicword
> > > and read out the barebox image size.
> > > Create a inital partion of 1Mb to access the barebox image on nand.
> > >
> > > Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
> > > ---
> > > v2: remove fall back if header read fail
> > > v3: fix header check, rebase master
> > > v4: factorize barebox detection
> > >
> > > arch/arm/include/asm/barebox-arm-head.h | 9 +++++
> > > arch/arm/mach-omap/include/mach/xload.h | 2 +-
> > > arch/arm/mach-omap/xload.c | 57 ++++++++++++++++++++++++++++--
> > > common/filetype.c | 3 +-
> > this con not work
> >
> > common/filetype is use accross ARCH
> >
> > is_barebox_arm_head need to be a inline returning false if not arm
> this is why I use the ugly #include
> "../arch/arm/include/asm/barebox-arm-head.h". By now we can detect
> filetype_arm_barebox even on non arm architectures. Is breaking this OK?
no it's not
> Jan
> >
> > Best Regards,
> > J.
> > > 4 files changed, 65 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/arch/arm/include/asm/barebox-arm-head.h b/arch/arm/include/asm/barebox-arm-head.h
> > > index 2c250e9..42bd239 100644
> > > --- a/arch/arm/include/asm/barebox-arm-head.h
> > > +++ b/arch/arm/include/asm/barebox-arm-head.h
> > > @@ -1,6 +1,15 @@
> > > #ifndef __ASM_ARM_HEAD_H
> > > #define __ASM_ARM_HEAD_H
> > >
> > > +#define ARM_HEAD_SIZE 0x30
> > > +#define HEAD_MAGICWORD_OFFSET 0x20
> > > +#define HEAD_SIZE_OFFSET 0x2C
> > > +
> > > +static inline int is_barebox_arm_head(const char *head)
> > > +{
> > > + return !strcmp(head + HEAD_MAGICWORD_OFFSET, "barebox");
> > > +}
put this in flietype.h
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-09-05 12:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 10:56 [RFC] " Jan Weitzel
2012-08-28 6:54 ` Sascha Hauer
2012-08-28 8:41 ` Jan Weitzel
2012-08-28 9:08 ` Sascha Hauer
2012-08-28 12:36 ` [PATCH v2] " Jan Weitzel
2012-08-29 6:59 ` Sascha Hauer
2012-08-29 8:01 ` Jan Weitzel
2012-08-29 9:10 ` [PATCH v3] " Jan Weitzel
2012-08-29 12:21 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-04 7:34 ` Jan Weitzel
2012-09-04 9:28 ` Sascha Hauer
2012-09-04 12:27 ` Jan Weitzel
2012-09-04 14:41 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-05 8:22 ` [PATCH v4] " Jan Weitzel
2012-09-05 10:34 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-05 11:37 ` Suspected ##SPAM## -:Re: " Jan Weitzel
2012-09-05 12:02 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905120224.GD32603@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=J.Weitzel@phytec.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox