From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] fec: restart autoneg at open instead of init
Date: Thu, 6 Sep 2012 23:52:05 +0200 [thread overview]
Message-ID: <20120906215205.GL20330@game.jcrosoft.org> (raw)
In-Reply-To: <1346960309-3999-1-git-send-email-eric@eukrea.com>
On 21:38 Thu 06 Sep , Eric Bénard wrote:
> this saves some time during boot when ethernet is not needed in barebox
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
Wait I'm going to drop this to have the phy init only at the open of the net
on all drivers
Best Regards,
J.
> drivers/net/fec_imx.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
> index 599a9b4..2bc06a9 100644
> --- a/drivers/net/fec_imx.c
> +++ b/drivers/net/fec_imx.c
> @@ -347,9 +347,6 @@ static int fec_init(struct eth_device *dev)
> /* size of each buffer */
> writel(FEC_MAX_PKT_SIZE, fec->regs + FEC_EMRBR);
>
> - if (fec->xcv_type != SEVENWIRE)
> - miidev_restart_aneg(&fec->miidev);
> -
> return 0;
> }
>
> @@ -363,6 +360,9 @@ static int fec_open(struct eth_device *edev)
> int ret;
> u32 ecr;
>
> + if (fec->xcv_type != SEVENWIRE)
> + miidev_restart_aneg(&fec->miidev);
> +
> /*
> * Initialize RxBD/TxBD rings
> */
> --
> 1.7.7.6
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-09-06 21:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 19:38 Eric Bénard
2012-09-06 21:52 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-09-10 7:43 ` Sascha Hauer
2012-09-10 7:51 ` Eric Bénard
2012-09-06 19:39 Eric Bénard
2012-09-07 6:57 ` Sascha Hauer
2012-09-07 7:30 ` Eric Bénard
2012-09-07 7:47 ` Sascha Hauer
2012-09-07 7:51 ` Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906215205.GL20330@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=eric@eukrea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox