Re: [PATCH 5/7] echo: always allow to pass -e option

From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/7] echo: always allow to pass -e option
Date: Fri, 7 Sep 2012 19:50:33 +0200	[thread overview]
Message-ID: <20120907175033.GY26594@pengutronix.de> (raw)
In-Reply-To: <1346848107-4664-5-git-send-email-plagnioj@jcrosoft.com>

On Wed, Sep 05, 2012 at 02:28:25PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> This will allow to do not taint if not enabled
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  commands/echo.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/commands/echo.c b/commands/echo.c
> index a19d992..566f5c2 100644
> --- a/commands/echo.c
> +++ b/commands/echo.c
> @@ -66,11 +66,11 @@ static int do_echo(int argc, char *argv[])
>  				goto no_optarg_out;
>  			optind++;
>  			break;
> -#ifdef CONFIG_CMD_ECHO_E
>  		case 'e':
> +#ifdef CONFIG_CMD_ECHO_E
>  			process_escape = 1;

Better:
			process_escape = IS_ENABLED(CONFIG_CMD_ECHO_E);

Sascha

> -			break;
>  #endif
> +			break;
>  		default:
>  			goto exit_parse;
>  		}
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox