Re: [PATCH 09/11] defaultenv-2: boot/net add bootp support

From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 09/11] defaultenv-2: boot/net add bootp support
Date: Sat, 8 Sep 2012 20:12:33 +0200	[thread overview]
Message-ID: <20120908181233.GL18243@pengutronix.de> (raw)
In-Reply-To: <20120908171440.GE20330@game.jcrosoft.org>

On Sat, Sep 08, 2012 at 07:14:40PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > > -nfsroot="/home/${global.user}/nfsroot/${global.hostname}"
> > > > > +
> > > > > +if [ -n "${global.dhcp.rootpath}" ]; then
> > > > > +	bootp=1
> > > > > +	nfsroot="${global.dhcp.rootpath}"
> > > > > +else
> > > > > +	nfsroot="/home/${global.user}/nfsroot/${global.hostname}"
> > > > > +fi
> > > > > +
> > > > > +if [ -n "${global.dhcp.bootfile}" -o -n "${global.dhcp.oftree_file}" ]; then
> > > > > +	bootp=1
> > > > > +	path="/mnt/dhcp"
> > > > > +
> > > > > +	if [ -d "${path}" ]; then
> > > > > +		umount "${path}"
> > > > > +	else
> > > > > +		mkdir "${path}"
> > > > > +	fi
> > > > > +	mount -t tftp $eth0.serverip "${path}"
> > > > 
> > > > That's exactly the path that's already mounted to /mnt/tftp. Why are you
> > > > doing this?
> > > evenif the ip is changed?
> > 
> > The ip won't change when you drop the ifdown/ifup above.
> the IP may change balance tftp

??

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox