From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alex Gershgorin <alexgershgorin@gmail.com>
Cc: barebox@lists.infradead.org, Alex Gershgorin <alexg@meprolight.com>
Subject: Re: [PATCH] video imx-ipu-fb: add clear screen
Date: Mon, 10 Sep 2012 09:36:32 +0200 [thread overview]
Message-ID: <20120910073632.GV18243@pengutronix.de> (raw)
In-Reply-To: <1347014799-23478-1-git-send-email-alexg@meprolight.com>
On Fri, Sep 07, 2012 at 01:46:39PM +0300, Alex Gershgorin wrote:
> This patch clear screen before usage
>
> Signed-off-by: Alex Gershgorin <alexg@meprolight.com>
> ---
> drivers/video/imx-ipu-fb.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/imx-ipu-fb.c b/drivers/video/imx-ipu-fb.c
> index 8039de0..d46cced 100644
> --- a/drivers/video/imx-ipu-fb.c
> +++ b/drivers/video/imx-ipu-fb.c
> @@ -1012,6 +1012,10 @@ static int imxfb_probe(struct device_d *dev)
> (info->bits_per_pixel >> 3));
> if (!fbi->info.screen_base)
> return -ENOMEM;
> +
> + /* Clear the screen */
> + memset((char *)fbi->info.screen_base, 0,
> + info->xres * info->yres * (info->bits_per_pixel >> 3));
Not clearing the screen is intentional. Normally the fb drivers do not
enable the framebuffer until explicitely requested via fb0.enable=1. The
environment normally is supposed to set a picture on the screen and
enable it afterwards.
That said, we can clear the screen as with MMU enabled this probably
does not take long time. But then it should be done in the fb core.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-09-10 7:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 10:46 Alex Gershgorin
2012-09-07 12:11 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-10 7:36 ` Sascha Hauer [this message]
2012-09-10 10:16 ` Alex Gershgorin
2012-09-11 7:44 ` Sascha Hauer
2012-09-11 10:14 ` Alex Gershgorin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910073632.GV18243@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=alexg@meprolight.com \
--cc=alexgershgorin@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox