mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <alex.aring@googlemail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] sandbox-unaligned: better usement of ifdef
Date: Tue, 11 Sep 2012 09:51:41 +0200	[thread overview]
Message-ID: <20120911075141.GJ18243@pengutronix.de> (raw)
In-Reply-To: <1347341445-2476-1-git-send-email-alex.aring@gmail.com>

On Tue, Sep 11, 2012 at 07:30:43AM +0200, Alexander Aring wrote:
> GCC versions below 4.6 don't set __BYTE_ORDER__
> with __ORDER_LITTLE_ENDIAN__. So it's better to use
> __BYTE_ORDER and __LITTLE_ENDIAN instead.
> 
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>

These fix some warnings on a 32bit sandbox build also for me.

Thanks, applied.

Sascha

> ---
>  arch/sandbox/include/asm/unaligned.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/sandbox/include/asm/unaligned.h b/arch/sandbox/include/asm/unaligned.h
> index 07c1ae4..d02da6e 100644
> --- a/arch/sandbox/include/asm/unaligned.h
> +++ b/arch/sandbox/include/asm/unaligned.h
> @@ -8,7 +8,7 @@
>  #include <linux/unaligned/access_ok.h>
>  #include <linux/unaligned/generic.h>
>  
> -#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
> +#if __BYTE_ORDER == __LITTLE_ENDIAN
>  #define get_unaligned __get_unaligned_le
>  #define put_unaligned __put_unaligned_le
>  #else
> -- 
> 1.7.12
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2012-09-11  7:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11  5:30 Alexander Aring
2012-09-11  5:30 ` [PATCH 2/3] sandbox: fix posix_types Alexander Aring
2012-09-11  5:30 ` [PATCH 3/3] sandbox: add missed case statement Alexander Aring
2012-09-11  7:51 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120911075141.GJ18243@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=alex.aring@googlemail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox