mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 09/11] filetype: add PNG support
Date: Wed, 12 Sep 2012 17:14:10 +0200	[thread overview]
Message-ID: <20120912151410.GU6180@pengutronix.de> (raw)
In-Reply-To: <1347457369-9215-9-git-send-email-plagnioj@jcrosoft.com>

On Wed, Sep 12, 2012 at 03:42:47PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  common/filetype.c  |    3 +++
>  include/filetype.h |    1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/common/filetype.c b/common/filetype.c
> index 5710394..0eaf119 100644
> --- a/common/filetype.c
> +++ b/common/filetype.c
> @@ -71,6 +71,7 @@ static int is_fat(u8 *buf)
>  enum filetype file_detect_type(void *_buf)
>  {
>  	u32 *buf = _buf;
> +	u64 *buf64 = _buf;
>  	u8 *buf8 = _buf;
>  
>  	if (strncmp(buf8, "#!/bin/sh", 9) == 0)
> @@ -103,6 +104,8 @@ enum filetype file_detect_type(void *_buf)
>  		return filetype_fat;
>  	if (strncmp(buf8, "BM", 2) == 0)
>  		return filetype_bmp;
> +	if (buf64[0] == le64_to_cpu(0x0a1a0a0d474e5089ull))
> +		return filetype_png;

The corresponding string in filetype_str is missing


>  
>  	return filetype_unknown;
>  }
> diff --git a/include/filetype.h b/include/filetype.h
> index 6c97159..2924032 100644
> --- a/include/filetype.h
> +++ b/include/filetype.h
> @@ -20,6 +20,7 @@ enum filetype {
>  	filetype_mips_barebox,
>  	filetype_fat,
>  	filetype_bmp,
> +	filetype_png,
>  };
>  
>  const char *file_type_to_string(enum filetype f);
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-09-12 15:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 13:24 [PATCH 00/11 v4] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 13:42 ` [PATCH 01/11] bmp: rename it to splash Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 13:42   ` [PATCH 02/11] bmp: split bmp rending in lib/bmp.c Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 15:08     ` Sascha Hauer
2012-09-12 15:18       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 15:24         ` Sascha Hauer
2012-09-12 13:42   ` [PATCH 03/11] Introduce graphic utils Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 13:42   ` [PATCH 04/11] introduce image_renderer framework Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 13:42   ` [PATCH 05/11] filetype: add BMP support Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 15:13     ` Sascha Hauer
2012-09-12 13:42   ` [PATCH 06/11] splash/bmp: switch to image_renderer Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 13:42   ` [PATCH 07/11] splash: add support to set a background color Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 13:42   ` [PATCH 08/11] graphic_utils: add rgba support Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 13:42   ` [PATCH 09/11] filetype: add PNG support Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 15:14     ` Sascha Hauer [this message]
2012-09-12 13:42   ` [PATCH 10/11] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 13:42   ` [PATCH 11/11] png: add picoPNG lib support Jean-Christophe PLAGNIOL-VILLARD
  -- strict thread matches above, loose matches on Subject: below --
2012-09-08 18:03 [PATCH 00/11 v3] add PNG support Jean-Christophe PLAGNIOL-VILLARD
2012-09-08 18:05 ` [PATCH 01/11] bmp: rename it to splash Jean-Christophe PLAGNIOL-VILLARD
2012-09-08 18:05   ` [PATCH 09/11] filetype: add PNG support Jean-Christophe PLAGNIOL-VILLARD
2012-09-07 13:07 [PATCH 00/11 v2] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-07 13:10 ` [PATCH 01/11] bmp: rename it to splash Jean-Christophe PLAGNIOL-VILLARD
2012-09-07 13:10   ` [PATCH 09/11] filetype: add PNG support Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120912151410.GU6180@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox