mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 6/7] dhcp: add retries limit support
Date: Thu, 13 Sep 2012 09:44:52 +0200	[thread overview]
Message-ID: <20120913074452.GG28928@game.jcrosoft.org> (raw)
In-Reply-To: <20120913074348.GF6180@pengutronix.de>

On 09:43 Thu 13 Sep     , Sascha Hauer wrote:
> On Thu, Sep 13, 2012 at 09:38:38AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 09:12 Thu 13 Sep     , Sascha Hauer wrote:
> > > On Wed, Sep 12, 2012 at 04:48:27PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > via -r opt, global.dhcp.retries or dhcp_retries
> > > > 
> > > > set the priority order;
> > > > 
> > > > This will allow to do not stay infinite loop if no dhcp availlable
> > > 
> > > s/availlable/available/
> > > 
> > > > @@ -746,11 +767,17 @@ static int do_dhcp(int argc, char *argv[])
> > > >  	while (dhcp_state != BOUND) {
> > > >  		if (ctrlc())
> > > >  			break;
> > > > +		if (!retries) {
> > > > +			ret = ETIMEDOUT;
> > > 
> > > -ETIMEDOUT
> > > 
> > > BTW currently we have in most commands:
> > > 
> > > 	return ret ? 1 : 0;
> > > 
> > > This is because the shell interpreted negative values as 'exit'. hush
> > > does not do this anymore, so now we can think about a path to just
> > > return negative error codes from the commands.
> > > 
> > > 
> > > > @@ -785,7 +812,8 @@ BAREBOX_CMD_HELP_OPT  ("-u <client_uuid>",
> > > >  BAREBOX_CMD_HELP_OPT  ("-U <user_class>",
> > > >  "DHCP User class (code 77) submitted in DHCP requests. It can\n"
> > > >  "be used in the DHCP server's configuration to select options\n"
> > > > -"(e.g. bootfile or server) which are valid for barebox clients only.\n");
> > > > +"(e.g. bootfile or server) which are valid for barebox clients only.\n")
> > > > +BAREBOX_CMD_HELP_OPT  ("-r <retry>", "retry limi\n");
> > > 
> > > s/limi/limit/
> > what do you think to put something else than infinite loop by default
> > 
> > I thinnk 20 is enough
> 
> Yes, ok, maybe even less. How long does one retry take?
3s each

so 20 it's 60s

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-09-13  7:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 14:27 [PATCH 0/7] dhcp: update to globalvar Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 14:48 ` [PATCH 1/7] globalbar: add inline when not enabled Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 14:48   ` [PATCH 2/7] defaultenv: enable glovalvar support Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 14:48   ` [PATCH 3/7] defaultenv: switch hostname to global.hostname Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 15:31     ` Sascha Hauer
2012-09-12 15:31       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 15:35       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 15:44     ` [PATCH 3/7 v2] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 14:48   ` [PATCH 4/7] dhcp: switch to global var support Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 14:48   ` [PATCH 5/7] dhcp: add copy_only_if_valid support Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 14:48   ` [PATCH 6/7] dhcp: add retries limit support Jean-Christophe PLAGNIOL-VILLARD
2012-09-13  7:12     ` Sascha Hauer
2012-09-13  7:23       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-13  7:38       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-13  7:43         ` Sascha Hauer
2012-09-13  7:44           ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-09-12 14:48   ` [PATCH 7/7] defaultenv-2: eth0 add default global.dhcp.vendor_id Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 15:06   ` [PATCH 1/7] globalbar: add inline when not enabled Sascha Hauer
2012-09-12 15:19     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-13 15:55 [PATCH 0/7 v2] dhcp: update to globalvar Jean-Christophe PLAGNIOL-VILLARD
2012-09-13 16:29 ` [PATCH 1/7] globalvar: add inline when not enabled Jean-Christophe PLAGNIOL-VILLARD
2012-09-13 16:29   ` [PATCH 6/7] dhcp: add retries limit support Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120913074452.GG28928@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox