mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] net: introduce phylib
Date: Sun, 16 Sep 2012 23:01:58 +0200	[thread overview]
Message-ID: <20120916210158.GL6180@pengutronix.de> (raw)
In-Reply-To: <1347818098-10408-1-git-send-email-plagnioj@jcrosoft.com>

On Sun, Sep 16, 2012 at 07:54:58PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Adapt phylib from linux
> 
> switch all the driver to it
> 
> This will allow to have
>  - phy drivers
>  - to only connect the phy at then opening of the device
>  - if the phy is not ready or not up fail on open
> 
> Same behaviour as in linux and will allow to share code and simplify porting.
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

> +/* Automatically gets and returns the PHY device */
> +int phy_device_connect(struct mii_device *bus, int addr,
> +		       void (*adjust_link) (struct eth_device *edev),
> +		       u32 flags, phy_interface_t interface)
> +{
> +	struct eth_device *edev = bus->edev;

You should pass in a struct eth_device pointer here instead of getting
it from bus->edev because a struct mii_device can have multiple ethernet
devices. The next step would be to remove the edev member from struct
mii_dev and add it to struct phy_device insted.

BTW no typedefs please. Use enum phy_interface instead.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-09-16 21:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-16 12:42 [PATCH 0/3 v4] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-16 13:45 ` [PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-16 18:07   ` Sascha Hauer
2012-09-17  5:23     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-16 17:54 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-16 21:01   ` Sascha Hauer [this message]
2012-09-17  5:20     ` Jean-Christophe PLAGNIOL-VILLARD
  -- strict thread matches above, loose matches on Subject: below --
2012-09-24  9:31 [PATCH 0/1 v7] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-24  9:36 ` [PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-22 10:07 [PATCH 0/1 v6] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-22 10:12 ` [PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-23 14:50   ` Sascha Hauer
2012-09-23 17:21     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-17  5:43 [PATCH 0/1 v5] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-17  5:59 ` [PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-17 14:13   ` Sascha Hauer
2012-09-17 14:26     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-07 10:26 Jean-Christophe PLAGNIOL-VILLARD
2012-09-08 15:02 ` Sascha Hauer
2012-09-08 17:28   ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120916210158.GL6180@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox