mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] defaultenv-2: execute init/* before timeout
Date: Wed, 19 Sep 2012 23:02:19 +0200	[thread overview]
Message-ID: <20120919210219.GN6180@pengutronix.de> (raw)
In-Reply-To: <20120919185721.GY25990@game.jcrosoft.org>

On Wed, Sep 19, 2012 at 08:57:21PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 18:53 Wed 19 Sep     , Sascha Hauer wrote:
> > On Wed, Sep 19, 2012 at 11:50:35AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > so we can have splah, usb serial, etc...
> > > 
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > ---
> > >  defaultenv-2/base/bin/init |    8 +++-----
> > >  1 file changed, 3 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/defaultenv-2/base/bin/init b/defaultenv-2/base/bin/init
> > > index 3cac41c..5524710 100644
> > > --- a/defaultenv-2/base/bin/init
> > > +++ b/defaultenv-2/base/bin/init
> > > @@ -12,7 +12,9 @@ global linux.bootargs.dyn.ip
> > >  global linux.bootargs.dyn.root
> > >  global editcmd=sedit
> > >  
> > > -/env/init/general
> > > +for i in /env/init/*; do
> > > +	. $i
> > > +done
> > >  
> > >  if [ -e /env/menu ]; then
> > >  	echo -e -n "\nHit m for menu or any other key to stop autoboot: "
> > > @@ -27,10 +29,6 @@ if [ "${key}" = "q" ]; then
> > >  	exit
> > >  fi
> > >  
> > > -for i in /env/init/*; do
> > > -	. $i
> > > -done
> > > -
> > 
> > This was intentionally done *after* waiting for user intervention to be
> > able to escape in case some init script crashes barebox.
> yeah but we need splash before timeout and I do not what to hack the init
> 
> so can do a pseudo rc.d
> 
> /etc/init/pre
> /etc/init/post
> 
> so we can have some before some after timeout

Don't overengineer. Just do a

timeout -s -a -v key 0
if [ "{$key}" = 'q' ]; then
	exit
fi

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-09-19 21:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19  9:50 Jean-Christophe PLAGNIOL-VILLARD
2012-09-19 16:53 ` Sascha Hauer
2012-09-19 18:57   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-19 21:02     ` Sascha Hauer [this message]
2013-01-15 20:43 Jean-Christophe PLAGNIOL-VILLARD
2013-01-16 20:32 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120919210219.GN6180@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox