From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 15.mo5.mail-out.ovh.net ([178.33.107.29] helo=mo5.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TEZSR-0003Yy-Rr for barebox@lists.infradead.org; Thu, 20 Sep 2012 05:37:52 +0000 Received: from mail404.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo5.mail-out.ovh.net (Postfix) with SMTP id 677F2FF953C for ; Thu, 20 Sep 2012 07:43:40 +0200 (CEST) Date: Thu, 20 Sep 2012 07:35:19 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20120920053519.GC26553@game.jcrosoft.org> References: <20120919144332.GX25990@game.jcrosoft.org> <1348066078-26482-1-git-send-email-plagnioj@jcrosoft.com> <1348066078-26482-2-git-send-email-plagnioj@jcrosoft.com> <20120919174153.GM6180@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120919174153.GM6180@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/5] sandbox: do not register device before base is started To: Sascha Hauer Cc: barebox@lists.infradead.org On 19:41 Wed 19 Sep , Sascha Hauer wrote: > On Wed, Sep 19, 2012 at 04:47:55PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > This will crash when use registered bus with device registered to it. > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > --- > > arch/sandbox/board/Makefile | 1 + > > arch/sandbox/board/console.c | 2 +- > > arch/sandbox/board/devices.c | 35 +++++++++++++++++++++++++++++++++++ > > arch/sandbox/board/hostfile.c | 19 +++++++++++++++++-- > > 4 files changed, 54 insertions(+), 3 deletions(-) > > create mode 100644 arch/sandbox/board/devices.c > > > > diff --git a/arch/sandbox/board/Makefile b/arch/sandbox/board/Makefile > > index 266c3a3..5104f5c 100644 > > --- a/arch/sandbox/board/Makefile > > +++ b/arch/sandbox/board/Makefile > > @@ -2,5 +2,6 @@ obj-y += board.o > > obj-y += clock.o > > obj-y += hostfile.o > > obj-y += console.o > > +obj-y += devices.o > > > > extra-y += barebox.lds > > diff --git a/arch/sandbox/board/console.c b/arch/sandbox/board/console.c > > index 18b63e1..b0afa54 100644 > > --- a/arch/sandbox/board/console.c > > +++ b/arch/sandbox/board/console.c > > @@ -44,6 +44,6 @@ int barebox_register_console(char *name, int stdinfd, int stdoutfd) > > data->stdoutfd = stdoutfd; > > data->stdinfd = stdinfd; > > > > - return register_device(dev); > > + return sandbox_add_device(dev); > > } > > > > diff --git a/arch/sandbox/board/devices.c b/arch/sandbox/board/devices.c > > new file mode 100644 > > index 0000000..d3fad78 > > --- /dev/null > > +++ b/arch/sandbox/board/devices.c > > @@ -0,0 +1,35 @@ > > +/* > > + * Copyright (c) 2012 Jean-Christophe PLAGNIOL-VILLARD > > + * > > + * Under GPLv2 only > > + */ > > + > > +#include > > +#include > > +#include > > + > > +static LIST_HEAD(sandbox_device_list); > > + > > +int sandbox_add_device(struct device_d *dev) > > +{ > > + if (!dev) > > + return -EINVAL; > > Can we please agree that everyone registering NULL pointers deserves a > nice crash? I do not see a reason to check this. All these kinds of > checks do is cover bugs and make tracking them down harder. I agree but not on the crash we need to use BUG_ON Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox