Re: [PATCH 1/1] net: introduce phylib

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 16:50 Sun 23 Sep     , Sascha Hauer wrote:
> On Sat, Sep 22, 2012 at 12:12:54PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Adapt phylib from linux
> > 
> > switch all the driver to it
> > reimplement mii bus
> > 
> > This will allow to have
> >  - phy drivers
> >  - to only connect the phy at then opening of the device
> >  - if the phy is not ready or not up fail on open
> > 
> > Same behaviour as in linux and will allow to share code and simplify porting.
> > 
> > + * get_phy_id - reads the specified addr for its ID.
> > + * @bus: the target MII bus
> > + * @addr: PHY address on the MII bus
> > + * @phy_id: where to store the ID retrieved.
> > + *
> > + * Description: Reads the ID registers of the PHY at @addr on the
> > + *   @bus, stores it in @phy_id and returns zero on success.
> > + */
> > +int get_phy_id(struct mii_bus *bus, int addr, u32 *phy_id)
> > +{
> > +	int phy_reg;
> > +
> > +	/* Grab the bits from PHYIR1, and put them
> > +	 * in the upper half */
> > +	phy_reg = mdiobus_read(bus, addr, MII_PHYSID1);
> > +
> > +	io (phy_reg < 0)
> > +		return -EIO;
> 
> Which gcc version do you use? Mine doesn't understand 'io'
edit patch by mistake when checking it

the tag should be ok
> 
> Please also fix this:
> 
> config:     ppc              pcm030_defconfig
> drivers/net/fec_mpc5200.c: In function 'mpc5xxx_fec_probe':
> drivers/net/fec_mpc5200.c:683:8: error: 'RMII' undeclared (first use in this function)
> drivers/net/fec_mpc5200.c:683:8: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/fec_mpc5200.c:686:8: error: 'RGMII' undeclared (first use inthis function)
> make[2]: *** [drivers/net/fec_mpc5200.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [drivers/net] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [drivers] Error 2
> make: *** Waiting for unfinished jobs....
this freescale driver is piss me off with it's copy and paste

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox