From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: "Jan Lübbe" <jlu@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] drivers gpio: Check for negativ gpio values
Date: Mon, 24 Sep 2012 11:34:08 +0200 [thread overview]
Message-ID: <20120924093408.GE26553@game.jcrosoft.org> (raw)
In-Reply-To: <1348478212.3491.1.camel@coredoba.hi.pengutronix.de>
On 11:16 Mon 24 Sep , Jan Lübbe wrote:
> On Mon, 2012-09-24 at 10:59 +0200, Teresa Gámez wrote:
> > static int gpio_is_valid(unsigned gpio)
> > {
> > - if (gpio < ARCH_NR_GPIOS)
> > + if (gpio < ARCH_NR_GPIOS && gpio >= 0)
>
> For an 'unsigned gpio', gpio >= 0 is always true.
unsigned is wrong type gpio need to int
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-09-24 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 8:59 Teresa Gámez
2012-09-24 8:59 ` [PATCH 2/2] ARM OMAP: switch to gpiolib support Teresa Gámez
2012-09-24 19:30 ` Sascha Hauer
2012-09-24 9:16 ` [PATCH 1/2] drivers gpio: Check for negativ gpio values Jan Lübbe
2012-09-24 9:21 ` Teresa Gamez
2012-09-24 9:34 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924093408.GE26553@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=jlu@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox