From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [for next PATCH 1/1] macb: fix typos in the phy_interface
Date: Tue, 25 Sep 2012 08:31:35 +0200 [thread overview]
Message-ID: <20120925063135.GX1322@pengutronix.de> (raw)
In-Reply-To: <1348517321-28652-1-git-send-email-plagnioj@jcrosoft.com>
On Mon, Sep 24, 2012 at 10:08:41PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> the RMII is set a RGMII and the flags are only check if MII
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Applied, thanks
Sascha
> ---
> drivers/net/macb.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 15548cf..64970ba 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -439,13 +439,13 @@ static int macb_probe(struct device_d *dev)
> macb->miibus.priv = macb;
> macb->miibus.parent = dev;
>
> - if (pdata->flags & AT91SAM_ETHER_RMII) {
> - macb->interface = PHY_INTERFACE_MODE_RGMII;
> - } else {
> + if (pdata->flags & AT91SAM_ETHER_RMII)
> + macb->interface = PHY_INTERFACE_MODE_RMII;
> + else
> macb->interface = PHY_INTERFACE_MODE_MII;
> - macb->phy_flags = pdata->flags & AT91SAM_ETHER_FORCE_LINK ?
> +
> + macb->phy_flags = pdata->flags & AT91SAM_ETHER_FORCE_LINK ?
> PHYLIB_FORCE_LINK : 0;
> - }
>
> macb->rx_buffer = dma_alloc_coherent(CFG_MACB_RX_BUFFER_SIZE);
> macb->rx_ring = dma_alloc_coherent(CFG_MACB_RX_RING_SIZE * sizeof(struct macb_dma_desc));
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-09-25 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 20:08 Jean-Christophe PLAGNIOL-VILLARD
2012-09-25 6:31 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925063135.GX1322@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox