From: Sascha Hauer <s.hauer@pengutronix.de>
To: vj <vicencb@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/7] Improved an error message and solved a minor bug
Date: Wed, 26 Sep 2012 09:11:39 +0200 [thread overview]
Message-ID: <20120926071139.GH1322@pengutronix.de> (raw)
In-Reply-To: <1348613994-1793-2-git-send-email-vicencb@gmail.com>
On Wed, Sep 26, 2012 at 12:59:48AM +0200, vj wrote:
> ---
> arch/arm/lib/armlinux.c | 2 +-
> drivers/mci/omap_hsmmc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/lib/armlinux.c b/arch/arm/lib/armlinux.c
> index 191274e..74d59a9 100644
> --- a/arch/arm/lib/armlinux.c
> +++ b/arch/arm/lib/armlinux.c
> @@ -80,7 +80,7 @@ void armlinux_set_revision(unsigned int rev)
> #ifdef CONFIG_ENVIRONMENT_VARIABLES
> export_env_ull("armlinux_system_rev", rev);
> #else
> - return armlinux_system_rev;
> + armlinux_system_rev = rev;
> #endif
> }
>
> diff --git a/drivers/mci/omap_hsmmc.c b/drivers/mci/omap_hsmmc.c
> index e0b245b..e6f4e47 100644
> --- a/drivers/mci/omap_hsmmc.c
> +++ b/drivers/mci/omap_hsmmc.c
> @@ -238,7 +238,7 @@ static int mmc_init_setup(struct mci_host *mci, struct device_d *dev)
> start = get_time_ns();
> while ((readl(&mmc_base->sysstatus) & RESETDONE) == 0) {
> if (is_timeout(start, SECOND)) {
> - dev_dbg(hsmmc->dev, "timedout waiting for cc2!\n");
> + dev_dbg(hsmmc->dev, "timeout waiting for reset done\n");
> return -ETIMEDOUT;
> }
> }
This looks good, but it should be two patches. Please always give the
subject the context of the patches, that would be "ARM: ..." for the
first one and "mmc omap: ..."
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-09-26 7:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[RFC][PATCH] archosg9: add support for tablet>
2012-09-25 22:59 ` [PATCH 0/7] [RFC][PATCH] archosg9: add support for tablet vj
2012-09-25 22:59 ` [PATCH 1/7] Improved an error message and solved a minor bug vj
2012-09-26 7:11 ` Sascha Hauer [this message]
2012-09-25 22:59 ` [PATCH 2/7] added debug info for twl6030 vj
2012-09-25 22:59 ` [PATCH 3/7] OMAP specific changes vj
2012-09-26 7:18 ` Sascha Hauer
2012-09-25 22:59 ` [PATCH 4/7] Add USB booting capabilities to OMAP vj
2012-09-26 7:45 ` Sascha Hauer
2012-09-28 0:27 ` vj
2012-09-28 7:32 ` Sascha Hauer
2012-09-25 22:59 ` [PATCH 5/7] add console support over the same USB used for booting vj
2012-09-25 22:59 ` [PATCH 6/7] add filesystem " vj
2012-09-25 22:59 ` [PATCH 7/7] Add support for Archos G9 tablet vj
2012-09-26 3:57 ` [PATCH 0/7] [RFC][PATCH] archosg9: add support for tablet Antony Pavlov
2012-09-26 7:06 ` Sascha Hauer
2012-09-26 22:38 ` vj
2012-09-26 8:16 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120926071139.GH1322@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox