mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/1 v7] net: introduce phylib
Date: Wed, 26 Sep 2012 13:36:58 +0200	[thread overview]
Message-ID: <20120926113658.GP26553@game.jcrosoft.org> (raw)
In-Reply-To: <20120926113116.GN1322@pengutronix.de>

On 13:31 Wed 26 Sep     , Sascha Hauer wrote:
> On Wed, Sep 26, 2012 at 01:20:07PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 13:02 Wed 26 Sep     , Sascha Hauer wrote:
> > > 
> > > barebox@Freescale i.MX51 PDK:/ dhcp 
> > > T transmission timeout
> > > T T transmission timeout
> > > T T transmission timeout
> > > T T transmission timeout
> > > T T transmission timeout
> > > 
> > > Plugging in a cable does not help, since the link status is only
> > > evaluated once during eth_open. If then a cable is plugged, adjust_link
> > > is never called, so the driver never adjusts to the actual link.
> > no this should not happend with the current code
> 
> Appearantly the code does not know what should and what should not
> happen.
> 
> > eth_send set the device as not active if eth_open failled of phy is not up
> 
> eth_send doesn't, but eth_rx does.
no it really in eth_send I found the bug I did a mistake in v7 I drop a check
in eth_send that report the phy down

I send the fix

Best Regards,
J.
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-09-26 11:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24  9:31 Jean-Christophe PLAGNIOL-VILLARD
2012-09-24  9:36 ` [PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-24 19:20 ` [PATCH 0/1 v7] " Sascha Hauer
2012-09-24 20:14   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-25 17:26 ` Jan Lübbe
2012-09-25 18:19   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 11:02 ` Sascha Hauer
2012-09-26 11:20   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 11:31     ` Sascha Hauer
2012-09-26 11:36       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-09-26 11:37   ` [PATCH 1/2] calao: at91 qil/tny/usb auto detect the phy addr Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 11:37     ` [PATCH 2/2] net/eth: fix missing check on eth active Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 11:53     ` [PATCH 3/3] net/eth: fix link handling Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 12:43       ` Sascha Hauer
2012-09-26 12:50         ` Jan Lübbe
2012-09-26 13:03           ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 13:08             ` Sascha Hauer
2012-09-26 13:43               ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 13:05         ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 13:59 ` [PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 15:17   ` Sascha Hauer
2012-09-26 15:51     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-02 14:44 ` [PATCH 0/1 v7] net: introduce phylib Renaud Barbier
2012-10-02 16:04   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-02 16:58     ` Sascha Hauer
2012-10-02 18:32       ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120926113658.GP26553@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox