From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] net: Add tftp command which uses the new tftp code
Date: Thu, 27 Sep 2012 22:24:43 +0200 [thread overview]
Message-ID: <20120927202443.GX1322@pengutronix.de> (raw)
In-Reply-To: <20120927193412.GE26553@game.jcrosoft.org>
On Thu, Sep 27, 2012 at 09:34:12PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 19:22 Thu 27 Sep , Sascha Hauer wrote:
> > Traditionally tftp is a command of its own. Since we can
> > mount tftp as a filesystem we have duplicated the tftp code, the old
> > code is used by the tftp command, the new by the filesystem support.
> > This adds a tftp command based on the filesystem support to preserve
> > backward compatibility. This allows us to remove the old tftp support
> > in the next step.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > commands/Kconfig | 8 +++++
> > commands/Makefile | 1 +
> > commands/tftp.c | 103 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> why this is c code?
>
> why not simply do it via script
Because c code is robust, cleans up after itself when the user presses
ctrl-c and is present also when the environment contains garbage because
of broken dependencies.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-09-27 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 17:22 [PATCH] use fs based tftp support Sascha Hauer
2012-09-27 17:22 ` [PATCH 1/3] net: Add tftp command which uses the new tftp code Sascha Hauer
2012-09-27 19:34 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-27 20:24 ` Sascha Hauer [this message]
2012-09-27 17:22 ` [PATCH 2/3] defconfig: Switch all defconfig to new tftp command Sascha Hauer
2012-09-27 17:22 ` [PATCH 3/3] net: remove old tftp support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927202443.GX1322@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox