From: Sascha Hauer <s.hauer@pengutronix.de>
To: vj <vicencb@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/9] twl6030: add debug info
Date: Tue, 2 Oct 2012 15:46:31 +0200 [thread overview]
Message-ID: <20121002134631.GX1322@pengutronix.de> (raw)
In-Reply-To: <1348973437-31132-5-git-send-email-vicencb@gmail.com>
On Sun, Sep 30, 2012 at 04:50:32AM +0200, vj wrote:
> ---
> drivers/mfd/twl6030.c | 22 ++++++++++++++++++++++
> include/mfd/twl6030.h | 8 ++++++++
> 2 files changed, 30 insertions(+)
>
> diff --git a/drivers/mfd/twl6030.c b/drivers/mfd/twl6030.c
> index 7ecfed8..b8b0418 100644
> --- a/drivers/mfd/twl6030.c
> +++ b/drivers/mfd/twl6030.c
> @@ -39,6 +39,28 @@ static int twl_probe(struct device_d *dev)
>
> devfs_create(&(twl_dev->core.cdev));
>
> +#ifdef DEBUG
> + {
> + u8 i, jtag_rev, eprom_rev;
> + int r;
> + u64 dieid;
> + r = twl6030_reg_read(twl_dev, TWL6030_JTAG_JTAGVERNUM,
> + &jtag_rev);
> + r |= twl6030_reg_read(twl_dev, TWL6030_JTAG_EPROM_REV,
> + &eprom_rev);
> + for (i = 0; i < 8; i++)
> + r |= twl6030_reg_read(twl_dev, TWL6030_DIEID_0+i,
> + ((u8 *)(&dieid))+i);
> + if (r)
> + debug("TWL6030 Error reading ID\n");
> + else
> + debug("TWL6030 JTAG REV: 0x%02X, "
> + "EPROM REV: 0x%02X, "
> + "DIE ID: 0x%016llX\n",
> + (unsigned)jtag_rev, (unsigned)eprom_rev, dieid);
Please use dev_dbg for driver/device related messages. dev_dbg will add
the correct context to the message.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-02 13:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 2:50 [PATCH 0/9] archosg9: add support for tablet, second round vj
2012-09-30 2:50 ` [PATCH 1/9] ARM: set rev instead of returning it vj
2012-09-30 2:50 ` [PATCH 2/9] mmc_omap: improve error message vj
2012-09-30 2:50 ` [PATCH 3/9] omap4: add/rename definitions to match datasheet vj
2012-09-30 2:50 ` [PATCH 4/9] twl6030: add debug info vj
2012-09-30 13:50 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-02 13:46 ` Sascha Hauer [this message]
2012-09-30 2:50 ` [PATCH 5/9] add gitignore file vj
2012-09-30 2:50 ` [PATCH 6/9] omap4: add usb boot support vj
2012-09-30 12:14 ` Antony Pavlov
2012-09-30 14:02 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-30 15:02 ` vj
2012-09-30 15:29 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-30 16:00 ` vj
2012-10-01 12:48 ` Sascha Hauer
2012-09-30 14:07 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-30 15:23 ` vj
2012-09-30 15:30 ` vj
[not found] ` <CAAMcf8B0Qif3zVfw44zx5G813fYrMQTfUKi86Kr+JuFm=yf5rQ@mail.gmail.com>
2012-09-30 15:32 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-02 13:51 ` Sascha Hauer
2012-09-30 2:50 ` [PATCH 7/9] omap4: add serial communications over usb boot vj
2012-09-30 2:50 ` [PATCH 8/9] omap4: add filesystem support " vj
2012-09-30 13:53 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-30 2:50 ` [PATCH 9/9] Add support for Archos G9 tablet vj
2012-09-30 14:00 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-30 15:02 ` Antony Pavlov
2012-10-02 17:06 ` [PATCH 0/9] archosg9: add support for tablet, second round Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002134631.GX1322@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox