* [PATCH] ARM pbl: Make usage of MMU in pbl optional @ 2012-10-03 10:24 Sascha Hauer 2012-10-03 11:35 ` Jean-Christophe PLAGNIOL-VILLARD 0 siblings, 1 reply; 7+ messages in thread From: Sascha Hauer @ 2012-10-03 10:24 UTC (permalink / raw) To: barebox Since this currently does not work on all boards make usage of the MMU in the pbl optional until this has been resolved. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- arch/arm/cpu/start-pbl.c | 2 +- common/Kconfig | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm/cpu/start-pbl.c b/arch/arm/cpu/start-pbl.c index 932a3da..ceb60ab 100644 --- a/arch/arm/cpu/start-pbl.c +++ b/arch/arm/cpu/start-pbl.c @@ -116,7 +116,7 @@ static void mmu_disable(void) static void barebox_uncompress(void *compressed_start, unsigned int len) { void (*barebox)(void); - int use_mmu = IS_ENABLED(CONFIG_MMU); + int use_mmu = IS_ENABLED(CONFIG_PBL_USE_MMU); /* set 128 KiB at the end of the MALLOC_BASE for early malloc */ free_mem_ptr = MALLOC_BASE + MALLOC_SIZE - SZ_128K; diff --git a/common/Kconfig b/common/Kconfig index b97392c..7e4cf1f 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -139,6 +139,11 @@ config IMAGE_COMPRESSION_GZIP endchoice +config PBL_USE_MMU + bool "Use MMU in PBL image" + help + say yes here to enable the MMU in the PBL image. This speeds up + booting, but has problems on some boards. endif endif -- 1.7.10.4 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM pbl: Make usage of MMU in pbl optional 2012-10-03 10:24 [PATCH] ARM pbl: Make usage of MMU in pbl optional Sascha Hauer @ 2012-10-03 11:35 ` Jean-Christophe PLAGNIOL-VILLARD 2012-10-03 12:30 ` Sascha Hauer 0 siblings, 1 reply; 7+ messages in thread From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-03 11:35 UTC (permalink / raw) To: Sascha Hauer; +Cc: barebox On 12:24 Wed 03 Oct , Sascha Hauer wrote: > Since this currently does not work on all boards make usage > of the MMU in the pbl optional until this has been resolved. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > arch/arm/cpu/start-pbl.c | 2 +- > common/Kconfig | 5 +++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/cpu/start-pbl.c b/arch/arm/cpu/start-pbl.c > index 932a3da..ceb60ab 100644 > --- a/arch/arm/cpu/start-pbl.c > +++ b/arch/arm/cpu/start-pbl.c > @@ -116,7 +116,7 @@ static void mmu_disable(void) > static void barebox_uncompress(void *compressed_start, unsigned int len) > { > void (*barebox)(void); > - int use_mmu = IS_ENABLED(CONFIG_MMU); > + int use_mmu = IS_ENABLED(CONFIG_PBL_USE_MMU); > > /* set 128 KiB at the end of the MALLOC_BASE for early malloc */ > free_mem_ptr = MALLOC_BASE + MALLOC_SIZE - SZ_128K; > diff --git a/common/Kconfig b/common/Kconfig > index b97392c..7e4cf1f 100644 > --- a/common/Kconfig > +++ b/common/Kconfig > @@ -139,6 +139,11 @@ config IMAGE_COMPRESSION_GZIP > > endchoice > > +config PBL_USE_MMU > + bool "Use MMU in PBL image" default y if MMU Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM pbl: Make usage of MMU in pbl optional 2012-10-03 11:35 ` Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-03 12:30 ` Sascha Hauer 2012-10-03 12:34 ` Jean-Christophe PLAGNIOL-VILLARD 0 siblings, 1 reply; 7+ messages in thread From: Sascha Hauer @ 2012-10-03 12:30 UTC (permalink / raw) To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox On Wed, Oct 03, 2012 at 01:35:50PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 12:24 Wed 03 Oct , Sascha Hauer wrote: > > Since this currently does not work on all boards make usage > > of the MMU in the pbl optional until this has been resolved. > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > --- > > arch/arm/cpu/start-pbl.c | 2 +- > > common/Kconfig | 5 +++++ > > 2 files changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/cpu/start-pbl.c b/arch/arm/cpu/start-pbl.c > > index 932a3da..ceb60ab 100644 > > --- a/arch/arm/cpu/start-pbl.c > > +++ b/arch/arm/cpu/start-pbl.c > > @@ -116,7 +116,7 @@ static void mmu_disable(void) > > static void barebox_uncompress(void *compressed_start, unsigned int len) > > { > > void (*barebox)(void); > > - int use_mmu = IS_ENABLED(CONFIG_MMU); > > + int use_mmu = IS_ENABLED(CONFIG_PBL_USE_MMU); > > > > /* set 128 KiB at the end of the MALLOC_BASE for early malloc */ > > free_mem_ptr = MALLOC_BASE + MALLOC_SIZE - SZ_128K; > > diff --git a/common/Kconfig b/common/Kconfig > > index b97392c..7e4cf1f 100644 > > --- a/common/Kconfig > > +++ b/common/Kconfig > > @@ -139,6 +139,11 @@ config IMAGE_COMPRESSION_GZIP > > > > endchoice > > > > +config PBL_USE_MMU > > + bool "Use MMU in PBL image" > default y if MMU Can do, but can you then send a patch for the defconfigs which don't work with MMU in the pbl? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM pbl: Make usage of MMU in pbl optional 2012-10-03 12:30 ` Sascha Hauer @ 2012-10-03 12:34 ` Jean-Christophe PLAGNIOL-VILLARD 2012-10-03 14:12 ` Sascha Hauer 0 siblings, 1 reply; 7+ messages in thread From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-03 12:34 UTC (permalink / raw) To: Sascha Hauer; +Cc: barebox On 14:30 Wed 03 Oct , Sascha Hauer wrote: > On Wed, Oct 03, 2012 at 01:35:50PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 12:24 Wed 03 Oct , Sascha Hauer wrote: > > > Since this currently does not work on all boards make usage > > > of the MMU in the pbl optional until this has been resolved. > > > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > > --- > > > arch/arm/cpu/start-pbl.c | 2 +- > > > common/Kconfig | 5 +++++ > > > 2 files changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/cpu/start-pbl.c b/arch/arm/cpu/start-pbl.c > > > index 932a3da..ceb60ab 100644 > > > --- a/arch/arm/cpu/start-pbl.c > > > +++ b/arch/arm/cpu/start-pbl.c > > > @@ -116,7 +116,7 @@ static void mmu_disable(void) > > > static void barebox_uncompress(void *compressed_start, unsigned int len) > > > { > > > void (*barebox)(void); > > > - int use_mmu = IS_ENABLED(CONFIG_MMU); > > > + int use_mmu = IS_ENABLED(CONFIG_PBL_USE_MMU); > > > > > > /* set 128 KiB at the end of the MALLOC_BASE for early malloc */ > > > free_mem_ptr = MALLOC_BASE + MALLOC_SIZE - SZ_128K; > > > diff --git a/common/Kconfig b/common/Kconfig > > > index b97392c..7e4cf1f 100644 > > > --- a/common/Kconfig > > > +++ b/common/Kconfig > > > @@ -139,6 +139,11 @@ config IMAGE_COMPRESSION_GZIP > > > > > > endchoice > > > > > > +config PBL_USE_MMU > > > + bool "Use MMU in PBL image" > > default y if MMU > > Can do, but can you then send a patch for the defconfigs which don't > work with MMU in the pbl? ok give one day to test all Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM pbl: Make usage of MMU in pbl optional 2012-10-03 12:34 ` Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-03 14:12 ` Sascha Hauer 2012-10-03 15:07 ` Jean-Christophe PLAGNIOL-VILLARD 2012-10-03 15:21 ` Jean-Christophe PLAGNIOL-VILLARD 0 siblings, 2 replies; 7+ messages in thread From: Sascha Hauer @ 2012-10-03 14:12 UTC (permalink / raw) To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox On Wed, Oct 03, 2012 at 02:34:35PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 14:30 Wed 03 Oct , Sascha Hauer wrote: > > On Wed, Oct 03, 2012 at 01:35:50PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > On 12:24 Wed 03 Oct , Sascha Hauer wrote: > > > > Since this currently does not work on all boards make usage > > > > of the MMU in the pbl optional until this has been resolved. > > > > > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > > > --- > > > > arch/arm/cpu/start-pbl.c | 2 +- > > > > common/Kconfig | 5 +++++ > > > > 2 files changed, 6 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm/cpu/start-pbl.c b/arch/arm/cpu/start-pbl.c > > > > index 932a3da..ceb60ab 100644 > > > > --- a/arch/arm/cpu/start-pbl.c > > > > +++ b/arch/arm/cpu/start-pbl.c > > > > @@ -116,7 +116,7 @@ static void mmu_disable(void) > > > > static void barebox_uncompress(void *compressed_start, unsigned int len) > > > > { > > > > void (*barebox)(void); > > > > - int use_mmu = IS_ENABLED(CONFIG_MMU); > > > > + int use_mmu = IS_ENABLED(CONFIG_PBL_USE_MMU); > > > > > > > > /* set 128 KiB at the end of the MALLOC_BASE for early malloc */ > > > > free_mem_ptr = MALLOC_BASE + MALLOC_SIZE - SZ_128K; > > > > diff --git a/common/Kconfig b/common/Kconfig > > > > index b97392c..7e4cf1f 100644 > > > > --- a/common/Kconfig > > > > +++ b/common/Kconfig > > > > @@ -139,6 +139,11 @@ config IMAGE_COMPRESSION_GZIP > > > > > > > > endchoice > > > > > > > > +config PBL_USE_MMU > > > > + bool "Use MMU in PBL image" > > > default y if MMU > > > > Can do, but can you then send a patch for the defconfigs which don't > > work with MMU in the pbl? > > ok give one day to test all Another plan. Since remap_cache currently does not work and I'm not confident enough to apply the fixups so close before a release we can equally well disable the feature for now. Ok? Sascha 8<------------------------------------------------------ From c05511d6cdbcddf32d41d4036e49af8a9c18832d Mon Sep 17 00:00:00 2001 From: Sascha Hauer <s.hauer@pengutronix.de> Date: Wed, 3 Oct 2012 12:23:41 +0200 Subject: [PATCH] ARM: Disable MMU feature in PBL remap_cache currently does not work, so enabling the MMU in the PBL currently does not make sense. Disable it for now. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- arch/arm/cpu/start-pbl.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/cpu/start-pbl.c b/arch/arm/cpu/start-pbl.c index 932a3da..3bd520c 100644 --- a/arch/arm/cpu/start-pbl.c +++ b/arch/arm/cpu/start-pbl.c @@ -116,7 +116,11 @@ static void mmu_disable(void) static void barebox_uncompress(void *compressed_start, unsigned int len) { void (*barebox)(void); - int use_mmu = IS_ENABLED(CONFIG_MMU); + /* + * remap_cached currently does not work rendering the feature + * of enabling the MMU in the PBL useless. disable for now. + */ + int use_mmu = 0; /* set 128 KiB at the end of the MALLOC_BASE for early malloc */ free_mem_ptr = MALLOC_BASE + MALLOC_SIZE - SZ_128K; -- 1.7.10.4 -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM pbl: Make usage of MMU in pbl optional 2012-10-03 14:12 ` Sascha Hauer @ 2012-10-03 15:07 ` Jean-Christophe PLAGNIOL-VILLARD 2012-10-03 15:21 ` Jean-Christophe PLAGNIOL-VILLARD 1 sibling, 0 replies; 7+ messages in thread From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-03 15:07 UTC (permalink / raw) To: Sascha Hauer; +Cc: barebox On 16:12 Wed 03 Oct , Sascha Hauer wrote: > On Wed, Oct 03, 2012 at 02:34:35PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 14:30 Wed 03 Oct , Sascha Hauer wrote: > > > On Wed, Oct 03, 2012 at 01:35:50PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > On 12:24 Wed 03 Oct , Sascha Hauer wrote: > > > > > Since this currently does not work on all boards make usage > > > > > of the MMU in the pbl optional until this has been resolved. > > > > > > > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > > > > --- > > > > > arch/arm/cpu/start-pbl.c | 2 +- > > > > > common/Kconfig | 5 +++++ > > > > > 2 files changed, 6 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/arch/arm/cpu/start-pbl.c b/arch/arm/cpu/start-pbl.c > > > > > index 932a3da..ceb60ab 100644 > > > > > --- a/arch/arm/cpu/start-pbl.c > > > > > +++ b/arch/arm/cpu/start-pbl.c > > > > > @@ -116,7 +116,7 @@ static void mmu_disable(void) > > > > > static void barebox_uncompress(void *compressed_start, unsigned int len) > > > > > { > > > > > void (*barebox)(void); > > > > > - int use_mmu = IS_ENABLED(CONFIG_MMU); > > > > > + int use_mmu = IS_ENABLED(CONFIG_PBL_USE_MMU); > > > > > > > > > > /* set 128 KiB at the end of the MALLOC_BASE for early malloc */ > > > > > free_mem_ptr = MALLOC_BASE + MALLOC_SIZE - SZ_128K; > > > > > diff --git a/common/Kconfig b/common/Kconfig > > > > > index b97392c..7e4cf1f 100644 > > > > > --- a/common/Kconfig > > > > > +++ b/common/Kconfig > > > > > @@ -139,6 +139,11 @@ config IMAGE_COMPRESSION_GZIP > > > > > > > > > > endchoice > > > > > > > > > > +config PBL_USE_MMU > > > > > + bool "Use MMU in PBL image" > > > > default y if MMU > > > > > > Can do, but can you then send a patch for the defconfigs which don't > > > work with MMU in the pbl? > > > > ok give one day to test all > > Another plan. Since remap_cache currently does not work and > I'm not confident enough to apply the fixups so close before > a release we can equally well disable the feature for now. > > Ok? ok the pbl is mandatory on at91 due to barebox size issue we can live without MMU for one release Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM pbl: Make usage of MMU in pbl optional 2012-10-03 14:12 ` Sascha Hauer 2012-10-03 15:07 ` Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-03 15:21 ` Jean-Christophe PLAGNIOL-VILLARD 1 sibling, 0 replies; 7+ messages in thread From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-03 15:21 UTC (permalink / raw) To: Sascha Hauer; +Cc: barebox On 16:12 Wed 03 Oct , Sascha Hauer wrote: > On Wed, Oct 03, 2012 at 02:34:35PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 14:30 Wed 03 Oct , Sascha Hauer wrote: > > > On Wed, Oct 03, 2012 at 01:35:50PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > On 12:24 Wed 03 Oct , Sascha Hauer wrote: > > > > > Since this currently does not work on all boards make usage > > > > > of the MMU in the pbl optional until this has been resolved. > > > > > > > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > > > > --- > > > > > arch/arm/cpu/start-pbl.c | 2 +- > > > > > common/Kconfig | 5 +++++ > > > > > 2 files changed, 6 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/arch/arm/cpu/start-pbl.c b/arch/arm/cpu/start-pbl.c > > > > > index 932a3da..ceb60ab 100644 > > > > > --- a/arch/arm/cpu/start-pbl.c > > > > > +++ b/arch/arm/cpu/start-pbl.c > > > > > @@ -116,7 +116,7 @@ static void mmu_disable(void) > > > > > static void barebox_uncompress(void *compressed_start, unsigned int len) > > > > > { > > > > > void (*barebox)(void); > > > > > - int use_mmu = IS_ENABLED(CONFIG_MMU); > > > > > + int use_mmu = IS_ENABLED(CONFIG_PBL_USE_MMU); > > > > > > > > > > /* set 128 KiB at the end of the MALLOC_BASE for early malloc */ > > > > > free_mem_ptr = MALLOC_BASE + MALLOC_SIZE - SZ_128K; > > > > > diff --git a/common/Kconfig b/common/Kconfig > > > > > index b97392c..7e4cf1f 100644 > > > > > --- a/common/Kconfig > > > > > +++ b/common/Kconfig > > > > > @@ -139,6 +139,11 @@ config IMAGE_COMPRESSION_GZIP > > > > > > > > > > endchoice > > > > > > > > > > +config PBL_USE_MMU > > > > > + bool "Use MMU in PBL image" > > > > default y if MMU > > > > > > Can do, but can you then send a patch for the defconfigs which don't > > > work with MMU in the pbl? > > > > ok give one day to test all > > Another plan. Since remap_cache currently does not work and > I'm not confident enough to apply the fixups so close before > a release we can equally well disable the feature for now. > > Ok? just for the record I work on ux5x0 for ST-E /ST Soc where you must enable the l2x0 to use the mmu And I get the same issue on nomadik that was alo on fo the reason I want to add the initcall to the pbl to have SoC and board init Best Regards, J. > > Sascha > > 8<------------------------------------------------------ > > From c05511d6cdbcddf32d41d4036e49af8a9c18832d Mon Sep 17 00:00:00 2001 > From: Sascha Hauer <s.hauer@pengutronix.de> > Date: Wed, 3 Oct 2012 12:23:41 +0200 > Subject: [PATCH] ARM: Disable MMU feature in PBL > > remap_cache currently does not work, so enabling the MMU in the > PBL currently does not make sense. Disable it for now. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > arch/arm/cpu/start-pbl.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/cpu/start-pbl.c b/arch/arm/cpu/start-pbl.c > index 932a3da..3bd520c 100644 > --- a/arch/arm/cpu/start-pbl.c > +++ b/arch/arm/cpu/start-pbl.c > @@ -116,7 +116,11 @@ static void mmu_disable(void) > static void barebox_uncompress(void *compressed_start, unsigned int len) > { > void (*barebox)(void); > - int use_mmu = IS_ENABLED(CONFIG_MMU); > + /* > + * remap_cached currently does not work rendering the feature > + * of enabling the MMU in the PBL useless. disable for now. > + */ > + int use_mmu = 0; > > /* set 128 KiB at the end of the MALLOC_BASE for early malloc */ > free_mem_ptr = MALLOC_BASE + MALLOC_SIZE - SZ_128K; > -- > 1.7.10.4 > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-10-03 15:24 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-10-03 10:24 [PATCH] ARM pbl: Make usage of MMU in pbl optional Sascha Hauer 2012-10-03 11:35 ` Jean-Christophe PLAGNIOL-VILLARD 2012-10-03 12:30 ` Sascha Hauer 2012-10-03 12:34 ` Jean-Christophe PLAGNIOL-VILLARD 2012-10-03 14:12 ` Sascha Hauer 2012-10-03 15:07 ` Jean-Christophe PLAGNIOL-VILLARD 2012-10-03 15:21 ` Jean-Christophe PLAGNIOL-VILLARD
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox