From: Sascha Hauer <s.hauer@pengutronix.de>
To: vj <vicencb@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 05/11] omap: revert gpiolib
Date: Sun, 7 Oct 2012 12:11:30 +0200 [thread overview]
Message-ID: <20121007101130.GC1322@pengutronix.de> (raw)
In-Reply-To: <1349476393-25520-6-git-send-email-vicencb@gmail.com>
On Sat, Oct 06, 2012 at 12:33:07AM +0200, vj wrote:
> This patch reverts 29e4031b460d1c84c1a8fc276199d40680b354d4.
> This is not meant to revert the gpiolib, this is only a temporal
> workaround because it breaks support for ArchosG9 tablet.
> Please, can anybody check if using gpiolib works for other omap4460
> based boards?
Teresa, have you tested this on OMAP4?
I can't find anything obviously wrong int this patch.
>
> -static int omap_gpio_probe(struct device_d *dev)
> -{
> - struct omap_gpio_chip *omapgpio;
> + gpio_set_value(gpio, value);
>
> - omapgpio = xzalloc(sizeof(*omapgpio));
> - omapgpio->base = dev_request_mem_region(dev, 0);
> - omapgpio->chip.ops = &omap_gpio_ops;
> - omapgpio->chip.base = -1;
base should be calculated as dev->id * 32. Otherwise the gpio numbering
gets depended on the probe order.
> - omapgpio->chip.ngpio = 32;
> - omapgpio->chip.dev = dev;
> - gpiochip_add(&omapgpio->chip);
> + reg += OMAP_GPIO_OE;
>
> - dev_dbg(dev, "probed gpiochip%d with base %d\n",
> - dev->id, omapgpio->chip.base);
> + val = __raw_readl(reg);
> + val &= ~(1 << get_gpio_index(gpio));
> + __raw_writel(val, reg);
>
> return 0;
> }
[...]
>
> -coredevice_initcall(omap3_gpio_init);
> diff --git a/arch/arm/mach-omap/omap4_generic.c b/arch/arm/mach-omap/omap4_generic.c
> index 584d724..6562268 100644
> --- a/arch/arm/mach-omap/omap4_generic.c
> +++ b/arch/arm/mach-omap/omap4_generic.c
> @@ -574,22 +574,3 @@ const struct gpmc_config omap4_nand_cfg = {
> .base = 0x28000000,
> .size = GPMC_SIZE_16M,
> };
> -
> -static int omap4_gpio_init(void)
> -{
> - add_generic_device("omap-gpio", 0, NULL, 0x4a310100,
> - 0x1000, IORESOURCE_MEM, NULL);
It seems on OMAP4 the register addresses are at an additional 0x100
offset compared to OMAP3. This little trick here to compensate that
will lead to problems should we add devicetree support for omap. For
now it's ok, but the region size should be reduced to 0x0f00 so that
there's no risk that it overlaps with the next region.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-07 10:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 22:33 [PATCH 00/11] archosg9: add support for tablet, third round vj
2012-10-05 22:33 ` [PATCH 01/11] regression: reset can not return vj
2012-10-07 9:42 ` Sascha Hauer
2012-10-05 22:33 ` [PATCH 02/11] twl6030: add debug info vj
2012-10-06 9:30 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-05 22:33 ` [PATCH 03/11] omap4: add/rename definitions to match datasheet vj
2012-10-05 22:33 ` [PATCH 04/11] ARM: ensure irqs are disabled vj
2012-10-07 9:46 ` Sascha Hauer
2012-10-05 22:33 ` [PATCH 05/11] omap: revert gpiolib vj
2012-10-07 10:11 ` Sascha Hauer [this message]
2012-10-09 6:30 ` Teresa Gamez
2012-10-09 6:54 ` Sascha Hauer
2012-10-05 22:33 ` [PATCH 06/11] omap4: add support for booting an omap4 from usb vj
2012-10-07 10:23 ` Sascha Hauer
2012-10-05 22:33 ` [PATCH 07/11] omap4: add serial communications over usb boot vj
2012-10-05 22:33 ` [PATCH 08/11] omap4: add filesystem support " vj
2012-10-05 22:33 ` [PATCH 09/11] omap4: add support for loading second stage from usb vj
2012-10-05 22:33 ` [PATCH 10/11] mach-types: add ID for Archos G9 tablet vj
2012-10-07 10:30 ` Sascha Hauer
2012-10-07 12:07 ` vj
2012-10-07 12:16 ` Sascha Hauer
2012-10-07 12:26 ` vj
2012-10-07 13:33 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 13:29 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-05 22:33 ` [PATCH 11/11] Add support " vj
2012-10-07 10:34 ` [PATCH 00/11] archosg9: add support for tablet, third round Sascha Hauer
2012-10-07 12:12 ` vj
2012-10-07 12:23 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121007101130.GC1322@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox