From: Sascha Hauer <s.hauer@pengutronix.de>
To: vj <vicencb@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 00/11] archosg9: add support for tablet, third round
Date: Sun, 7 Oct 2012 14:23:07 +0200 [thread overview]
Message-ID: <20121007122307.GJ1322@pengutronix.de> (raw)
In-Reply-To: <CAAMcf8AppGVVgLmMG7YvFpE32-zu-3dmmim-MRtNvfFiVin23A@mail.gmail.com>
On Sun, Oct 07, 2012 at 02:12:26PM +0200, vj wrote:
> On Sun, Oct 7, 2012 at 12:34 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> >
> > Hi vj,
> >
> > On Sat, Oct 06, 2012 at 12:33:02AM +0200, vj wrote:
> > > Hello,
> > > here is the third round of patches including most of the
> > > modifications suggested by your comments, which are greatly
> > > appreciated. one of the modifications not done is the move of the
> > > usb-booting infrastructure into a driver. Jean, can you please add
> > > more information about this? Thanks.
> > >
> > > scripts/checkpatch.pl returns two errors: "Macros with complex values
> > > should be enclosed in parenthesis", but in this case parenthesis
> > > can't be added, any suggestion?
> >
> > Could you post the macros which give this error?
> >
> > Overall apart from the little comments I made the series looks quite
> > good now. Thanks, nice work ;)
> >
> > Sascha
> >
> > --
> > Pengutronix e.K. | |
> > Industrial Linux Solutions | http://www.pengutronix.de/ |
> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
>
> The macros are:
> #define TARGET_FORMAT 0x1B, BRIGHT, RED+30, BLACK+40
> #define HOST_FORMAT 0x1B, RESET, WHITE+30, BLACK+40
>
> which are used in this way:
> #define FORMAT "%c[%d;%d;%dm"
> #define host_print(fmt, arg...) printf(FORMAT fmt FORMAT"\n",
> HOST_FORMAT, ##arg, TARGET_FORMAT)
> printf(FORMAT, TARGET_FORMAT);
>
> The reason is that scripts/omap4_usbboot has to print two types of
> messages, the ones comming from the OMAP4 and the ones coming from the
> PC. This is the way chosen to differentiate them.
Let's ignore the warnings. In the end they are just warnings. The 'use
checkpath' answer is just a simple way for reviewers to say that the
patch has coding style issues without having to go into details.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-10-07 12:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 22:33 vj
2012-10-05 22:33 ` [PATCH 01/11] regression: reset can not return vj
2012-10-07 9:42 ` Sascha Hauer
2012-10-05 22:33 ` [PATCH 02/11] twl6030: add debug info vj
2012-10-06 9:30 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-05 22:33 ` [PATCH 03/11] omap4: add/rename definitions to match datasheet vj
2012-10-05 22:33 ` [PATCH 04/11] ARM: ensure irqs are disabled vj
2012-10-07 9:46 ` Sascha Hauer
2012-10-05 22:33 ` [PATCH 05/11] omap: revert gpiolib vj
2012-10-07 10:11 ` Sascha Hauer
2012-10-09 6:30 ` Teresa Gamez
2012-10-09 6:54 ` Sascha Hauer
2012-10-05 22:33 ` [PATCH 06/11] omap4: add support for booting an omap4 from usb vj
2012-10-07 10:23 ` Sascha Hauer
2012-10-05 22:33 ` [PATCH 07/11] omap4: add serial communications over usb boot vj
2012-10-05 22:33 ` [PATCH 08/11] omap4: add filesystem support " vj
2012-10-05 22:33 ` [PATCH 09/11] omap4: add support for loading second stage from usb vj
2012-10-05 22:33 ` [PATCH 10/11] mach-types: add ID for Archos G9 tablet vj
2012-10-07 10:30 ` Sascha Hauer
2012-10-07 12:07 ` vj
2012-10-07 12:16 ` Sascha Hauer
2012-10-07 12:26 ` vj
2012-10-07 13:33 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 13:29 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-05 22:33 ` [PATCH 11/11] Add support " vj
2012-10-07 10:34 ` [PATCH 00/11] archosg9: add support for tablet, third round Sascha Hauer
2012-10-07 12:12 ` vj
2012-10-07 12:23 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121007122307.GJ1322@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox