From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TKpsz-0007PZ-I2 for barebox@lists.infradead.org; Sun, 07 Oct 2012 12:23:10 +0000 Date: Sun, 7 Oct 2012 14:23:07 +0200 From: Sascha Hauer Message-ID: <20121007122307.GJ1322@pengutronix.de> References: <1349476393-25520-1-git-send-email-vicencb@gmail.com> <20121007103434.GF1322@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 00/11] archosg9: add support for tablet, third round To: vj Cc: barebox@lists.infradead.org On Sun, Oct 07, 2012 at 02:12:26PM +0200, vj wrote: > On Sun, Oct 7, 2012 at 12:34 PM, Sascha Hauer wrote: > > > > Hi vj, > > > > On Sat, Oct 06, 2012 at 12:33:02AM +0200, vj wrote: > > > Hello, > > > here is the third round of patches including most of the > > > modifications suggested by your comments, which are greatly > > > appreciated. one of the modifications not done is the move of the > > > usb-booting infrastructure into a driver. Jean, can you please add > > > more information about this? Thanks. > > > > > > scripts/checkpatch.pl returns two errors: "Macros with complex values > > > should be enclosed in parenthesis", but in this case parenthesis > > > can't be added, any suggestion? > > > > Could you post the macros which give this error? > > > > Overall apart from the little comments I made the series looks quite > > good now. Thanks, nice work ;) > > > > Sascha > > > > -- > > Pengutronix e.K. | | > > Industrial Linux Solutions | http://www.pengutronix.de/ | > > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > > The macros are: > #define TARGET_FORMAT 0x1B, BRIGHT, RED+30, BLACK+40 > #define HOST_FORMAT 0x1B, RESET, WHITE+30, BLACK+40 > > which are used in this way: > #define FORMAT "%c[%d;%d;%dm" > #define host_print(fmt, arg...) printf(FORMAT fmt FORMAT"\n", > HOST_FORMAT, ##arg, TARGET_FORMAT) > printf(FORMAT, TARGET_FORMAT); > > The reason is that scripts/omap4_usbboot has to print two types of > messages, the ones comming from the OMAP4 and the ones coming from the > PC. This is the way chosen to differentiate them. Let's ignore the warnings. In the end they are just warnings. The 'use checkpath' answer is just a simple way for reviewers to say that the patch has coding style issues without having to go into details. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox