From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TLJWF-0006a4-Uu for barebox@lists.infradead.org; Mon, 08 Oct 2012 20:01:40 +0000 Date: Mon, 8 Oct 2012 22:01:30 +0200 From: Sascha Hauer Message-ID: <20121008200130.GQ1322@pengutronix.de> References: <1349647287-28224-1-git-send-email-vicencb@gmail.com> <1349647287-28224-8-git-send-email-vicencb@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1349647287-28224-8-git-send-email-vicencb@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 07/13] uimage: improve transfer speed To: Vicente Cc: barebox@lists.infradead.org On Mon, Oct 08, 2012 at 12:01:21AM +0200, Vicente wrote: > > Signed-off-by: Vicente Do you have some numbers which cases this speeds up and how much? Sascha > --- > common/uimage.c | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/common/uimage.c b/common/uimage.c > index c72db41..18c5b01 100644 > --- a/common/uimage.c > +++ b/common/uimage.c > @@ -28,6 +28,8 @@ > #include > #include > #include > +#include > +#include > > #ifdef CONFIG_UIMAGE_MULTI > static inline int uimage_is_multi_image(struct uimage_handle *handle) > @@ -380,15 +382,35 @@ struct resource *file_to_sdram(const char *filename, unsigned long adr) > struct resource *res; > size_t size = BUFSIZ; > size_t ofs = 0; > + size_t now; > int fd; > + struct stat s; > > fd = open(filename, O_RDONLY); > if (fd < 0) > return NULL; > > - while (1) { > - size_t now; > + /* TODO: use fstat(fd, &s) when implemented and avoid reopening file */ > + if (stat(filename, &s) == 0 && s.st_size <= SZ_1G) { > + /* > + * As the file size is known we can read it at once and improve > + * transfer speed. > + */ > + res = request_sdram_region("image", adr, s.st_size); > + if (!res) { > + printf("unable to request SDRAM 0x%08lx-0x%08lx\n", > + adr, adr + s.st_size - 1); > + goto out; > + } > > + now = read_full(fd, (void *)(res->start), s.st_size); > + if (now < s.st_size) { > + release_sdram_region(res); > + res = NULL; > + } > + goto out; > + } > + while (1) { > res = request_sdram_region("image", adr, size); > if (!res) { > printf("unable to request SDRAM 0x%08lx-0x%08lx\n", > -- > 1.7.12.2 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox