From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM at91sam9260ek: remove unused reset entry
Date: Wed, 10 Oct 2012 10:46:37 +0200 [thread overview]
Message-ID: <20121010084637.GR27665@pengutronix.de> (raw)
In-Reply-To: <CAA4bVAGCbbrw0RmMdpDa88bF12Wjqp2FFixsKZ_-6wYyUKwcCQ@mail.gmail.com>
On Mon, Oct 08, 2012 at 04:24:18PM +0400, Antony Pavlov wrote:
> On 8 October 2012 16:15, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
> > On 13:02 Mon 08 Oct , Sascha Hauer wrote:
> >> The at91sam9260ek has a custom reset function which does the same thing
> >> as the default function. Also it does not define MACH_HAS_LOWLEVEL_INIT
> >> as it should do. Remove the function.
> >>
> >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >> ---
> > Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> >
> > btw we should rename the command reset reboot because it start to be confusing
>
> IMHO it is a very good idea!
I would rather use a different name for the reset functions which are in
the startup code. In the end the reset command just resets the board.
'reboot' sounds like something is being shutdown before restarting a
board.
Changing a command is quite painful since all environment scripts will
be broken. I don't think reset is used in the environment, but the
API change to the mount command always nags me when using a new barebox
which has an older environment in flash. I think we really have to be
more careful when changing commands.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-10 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 11:02 Sascha Hauer
2012-10-08 12:15 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-08 12:24 ` Antony Pavlov
2012-10-10 8:46 ` Sascha Hauer [this message]
2012-10-10 9:39 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-10 9:47 ` Sascha Hauer
2012-10-10 10:53 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010084637.GR27665@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox