From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM at91sam9260ek: remove unused reset entry
Date: Wed, 10 Oct 2012 12:53:23 +0200 [thread overview]
Message-ID: <20121010105323.GJ26553@game.jcrosoft.org> (raw)
In-Reply-To: <20121010094703.GZ27665@pengutronix.de>
On 11:47 Wed 10 Oct , Sascha Hauer wrote:
> On Wed, Oct 10, 2012 at 11:39:21AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 10:46 Wed 10 Oct , Sascha Hauer wrote:
> > > On Mon, Oct 08, 2012 at 04:24:18PM +0400, Antony Pavlov wrote:
> > > > On 8 October 2012 16:15, Jean-Christophe PLAGNIOL-VILLARD
> > > > <plagnioj@jcrosoft.com> wrote:
> > > > > On 13:02 Mon 08 Oct , Sascha Hauer wrote:
> > > > >> The at91sam9260ek has a custom reset function which does the same thing
> > > > >> as the default function. Also it does not define MACH_HAS_LOWLEVEL_INIT
> > > > >> as it should do. Remove the function.
> > > > >>
> > > > >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > > >> ---
> > > > > Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > > >
> > > > > btw we should rename the command reset reboot because it start to be confusing
> > > >
> > > > IMHO it is a very good idea!
> > >
> > > I would rather use a different name for the reset functions which are in
> > > the startup code. In the end the reset command just resets the board.
> > > 'reboot' sounds like something is being shutdown before restarting a
> > > board.
> > >
> > > Changing a command is quite painful since all environment scripts will
> > > be broken. I don't think reset is used in the environment, but the
> > > API change to the mount command always nags me when using a new barebox
> > > which has an older environment in flash. I think we really have to be
> > > more careful when changing commands.
> > reset means reset the screen in linux
> >
> > and I check nearly no one use reset in the env
> > execpt sam9g45 and defaultenv2
> >
> > when I ask to do not update the var to pass the arch number on arm you give
> > the invert comment env evolve and we do not want to loose tis freedom
>
> You are right, but still we have a problem in this area and I wanted to
> mention it. One way out could for example be that we introduce some
> version counter which we increase when incompatible changes occur. Then
> we could fall back to the default env. I haven't thought that to an end
> though.
agreed, I've add such info in the env for it's own format
maybe with a question to the end use the first time with a timeout
if he really want to keep the current one
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-10-10 10:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 11:02 Sascha Hauer
2012-10-08 12:15 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-08 12:24 ` Antony Pavlov
2012-10-10 8:46 ` Sascha Hauer
2012-10-10 9:39 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-10 9:47 ` Sascha Hauer
2012-10-10 10:53 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010105323.GJ26553@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox