From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default
Date: Fri, 12 Oct 2012 13:22:07 +0200 [thread overview]
Message-ID: <20121012112207.GK13639@game.jcrosoft.org> (raw)
In-Reply-To: <1350040608.82613350@f361.mail.ru>
On 15:16 Fri 12 Oct , Alexander Shiyan wrote:
> Fri, 12 Oct 2012 11:24:08 +0200 от Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>:
> > On 10:50 Fri 12 Oct , Alexander Shiyan wrote:
> > > Command is used in the scripts and it should be compiled in.
> > >
> > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > ---
> > > common/Kconfig | 2 ++
> > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/common/Kconfig b/common/Kconfig
> > > index 9210739..2783405 100644
> > > --- a/common/Kconfig
> > > +++ b/common/Kconfig
> > > @@ -564,6 +564,8 @@ config DEFAULT_ENVIRONMENT_GENERIC_NEW
> > > select CMD_GLOBAL
> > > select CMD_AUTOMOUNT
> > > select CMD_BASENAME
> > > + select CMD_ECHO
> > > + select CMD_ECHO_E
> > ECHO_E need to be optionnal as you may not want the color support
>
> For example, command below is not work properly without this option:
> echo -e -n "\nHit any key to stop autoboot: "
> shows as:
>
> running /env/bin/init...
> \nHit any key to stop autoboot: 0
> ^^
>
> and with CMD_ECHO_E option result is normal:
no -e is ignored if CMD_ECHO_E is not enabled I put this
asn need to be keep that way
so fix hit with an empty echo not by forcing -e
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-10-12 11:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 6:50 Alexander Shiyan
2012-10-12 6:50 ` [PATCH 2/2] defaultenv-2: Select CMD_EDIT by default if CMD_MENU_MANAGEMENT is selected Alexander Shiyan
2012-10-12 9:24 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-12 9:24 ` [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default Jean-Christophe PLAGNIOL-VILLARD
2012-10-12 11:16 ` Re[2]: " Alexander Shiyan
2012-10-12 11:22 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012112207.GK13639@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox