Re: [PATCH 4/5] BCM2835: add support (arch)

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Oct 16, 2012 at 08:04:44PM +0200, Carlo Caione wrote:
> +
> +static struct clk ref_3_clk = {
> +	.rate = 3 * 1000 * 1000,
> +};
> +
> +static struct clk ref_1_clk = {
> +	.rate = 1 * 1000 * 1000,
> +};

Add a 'select COMMON_CLK' to your Kconfig and do a:

	clk_dummy = clk_fixed("dummy", 0);
	clk_ref_3 = clk_fixed("ref3", 3 * 1000 * 1000);
	clk_ref_1 = clk_fixed("ref1", 1 * 1000 * 1000);

Then you can drop your clk code and get a clk_dump command
which you can use to see what clocks you have.

> +static int bcm2835_gpio_init(void)
> +{
> +	add_generic_device("bcm2835-gpio", 0, NULL, BCM2835_GPIO_BASE, 0xB0, IORESOURCE_MEM, NULL);
> +	return 0;
> +}
> +coredevice_initcall(bcm2835_gpio_init);
> +
> +static int bcm2835_clkdev_init(void)
> +{
> +	clkdev_add_table(clocks_lookups, ARRAY_SIZE(clocks_lookups));
> +	return 0;
> +}
> +postcore_initcall(bcm2835_clkdev_init);
> +
> +static int bcm2835_clocksource_init(void)
> +{
> +	add_generic_device("bcm2835-cs", DEVICE_ID_SINGLE, NULL, BCM2835_ST_BASE, 0x1C, IORESOURCE_MEM, NULL);
> +	return 0;
> +}
> +coredevice_initcall(bcm2835_clocksource_init);
> +

Please consolidate the initcalls. A single function for the three above
is enough.

> +void bcm2835_register_uart(void)

Please add the UART index to the function name.

> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

The address is wrong. Please remove this paragraph completly

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox