* [PATCH] Makefile: disable CDPATH
@ 2012-10-24 9:12 Wolfram Sang
2012-10-25 6:38 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2012-10-24 9:12 UTC (permalink / raw)
To: barebox; +Cc: Wolfram Sang
CDPATH has sideeffects when generating barebox_default_env.h (printing
the directory name into the header file), causing a build failure.
Disable it for the build.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---
Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Makefile b/Makefile
index 881680d..55262ad 100644
--- a/Makefile
+++ b/Makefile
@@ -136,6 +136,9 @@ ifeq ($(skip-makefile),)
PHONY += all
_all: all
+# CDPATH can have sideeffects; disable, since we do know where we want to cd to
+export CDPATH=
+
srctree := $(if $(KBUILD_SRC),$(KBUILD_SRC),$(CURDIR))
objtree := $(CURDIR)
src := $(srctree)
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Makefile: disable CDPATH
2012-10-24 9:12 [PATCH] Makefile: disable CDPATH Wolfram Sang
@ 2012-10-25 6:38 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2012-10-25 6:38 UTC (permalink / raw)
To: Wolfram Sang; +Cc: barebox
On Wed, Oct 24, 2012 at 11:12:20AM +0200, Wolfram Sang wrote:
> CDPATH has sideeffects when generating barebox_default_env.h (printing
> the directory name into the header file), causing a build failure.
> Disable it for the build.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Applied, thanks
Sascha
> ---
> Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 881680d..55262ad 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -136,6 +136,9 @@ ifeq ($(skip-makefile),)
> PHONY += all
> _all: all
>
> +# CDPATH can have sideeffects; disable, since we do know where we want to cd to
> +export CDPATH=
> +
> srctree := $(if $(KBUILD_SRC),$(KBUILD_SRC),$(CURDIR))
> objtree := $(CURDIR)
> src := $(srctree)
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-25 6:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-24 9:12 [PATCH] Makefile: disable CDPATH Wolfram Sang
2012-10-25 6:38 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox