From: "Eric Bénard" <eric@eukrea.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net phy: poll for a link
Date: Thu, 25 Oct 2012 14:18:23 +0200 [thread overview]
Message-ID: <20121025141823.7a7eb52e@eb-e6520> (raw)
In-Reply-To: <20121025091106.GP21588@game.jcrosoft.org>
Le Thu, 25 Oct 2012 11:11:06 +0200,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
> On 11:05 Thu 25 Oct , Eric Bénard wrote:
> > Le Thu, 25 Oct 2012 10:49:02 +0200,
> > Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
> >
> > > On 21:56 Wed 24 Oct , Eric Bénard wrote:
> > > > Hi,
> > > >
> > > > Le Wed, 24 Oct 2012 20:33:59 +0200,
> > > > Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
> > > >
> > > > > On 20:06 Wed 24 Oct , Sascha Hauer wrote:
> > > > > > Since we have phylib we have no instance which polls for a link. This
> > > > > > means that network boot often bails out after a powercycle or phy reset.
> > > > > > This changes the link status behaviour to:
> > > > > >
> > > > > > - Always check for a link if the last link test was unsuccesful
> > > > > > - If the last check was succesful, check for a link when the last
> > > > > > check is longer than 5 seconds ago
> > > > > > - Try to get a link for 5 seconds.
> > > > > 5 seconds is too long
> > > > >
> > > > > and check the link is wrong you need to check the autoneg
> > > > > the link may be down because no cable
> > > > >
> > > > and the autoneg can have been successful before the cable was
> > > > removed : how to you handle this cas ?
> > > the advertise tell you something change
> > >
> > > so you need to restart the autoneg
> > >
> > so I don't really understand why you don't want to use the link
> > information which seems to be the first thing to do before trying to
> > launch an autoneg but why not, let see the patches when they come.
> because if the link is down and the have no advertise meens the phy is really
> down and no need to wait
>
under which conditions can you have link down and advertise at the same
time ?
Eric
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-25 12:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 18:06 Sascha Hauer
2012-10-24 18:33 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-24 19:56 ` Eric Bénard
2012-10-25 8:49 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-25 9:05 ` Eric Bénard
2012-10-25 9:11 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-25 12:18 ` Eric Bénard [this message]
2012-10-25 6:37 ` Sascha Hauer
2012-10-28 11:21 ` Sascha Hauer
2012-10-28 12:31 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025141823.7a7eb52e@eb-e6520 \
--to=eric@eukrea.com \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox