mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] debug_ll: use const char* for PUTS_LL
@ 2012-10-28  9:15 Jean-Christophe PLAGNIOL-VILLARD
  2012-10-28  9:15 ` [PATCH 2/2] console: display Switch to console [csxx] when switching from debug_ll to real console Jean-Christophe PLAGNIOL-VILLARD
  2012-10-29  7:39 ` [PATCH 1/2] debug_ll: use const char* for PUTS_LL Sascha Hauer
  0 siblings, 2 replies; 6+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-28  9:15 UTC (permalink / raw)
  To: barebox

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
 include/debug_ll.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/debug_ll.h b/include/debug_ll.h
index a8bac27..c744573 100644
--- a/include/debug_ll.h
+++ b/include/debug_ll.h
@@ -30,7 +30,7 @@
 			     ch += (ch >= 10) ? 'a' - 10 : '0';\
 			     PUTC_LL (ch); }})
 
-static __inline__ void PUTS_LL(char * str)
+static __inline__ void PUTS_LL(const char * str)
 {
 	while (*str) {
 		if (*str == '\n') {
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 2/2] console: display Switch to console [csxx] when switching from debug_ll to real console
  2012-10-28  9:15 [PATCH 1/2] debug_ll: use const char* for PUTS_LL Jean-Christophe PLAGNIOL-VILLARD
@ 2012-10-28  9:15 ` Jean-Christophe PLAGNIOL-VILLARD
  2012-10-29 20:55   ` Sascha Hauer
  2012-10-29  7:39 ` [PATCH 1/2] debug_ll: use const char* for PUTS_LL Sascha Hauer
  1 sibling, 1 reply; 6+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-28  9:15 UTC (permalink / raw)
  To: barebox

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
 common/console.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/console.c b/common/console.c
index 2e8c973..fdd5f42 100644
--- a/common/console.c
+++ b/common/console.c
@@ -88,6 +88,9 @@ static int console_std_set(struct device_d *dev, struct param_d *param,
 	if (initialized < CONSOLE_INIT_FULL) {
 		char ch;
 		initialized = CONSOLE_INIT_FULL;
+		PUTS_LL("Switch to console [");
+		PUTS_LL(dev_name(dev));
+		PUTS_LL("]\n");
 		barebox_banner();
 		while (kfifo_getc(console_output_fifo, &ch) == 0)
 			console_putc(CONSOLE_STDOUT, ch);
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] debug_ll: use const char* for PUTS_LL
  2012-10-28  9:15 [PATCH 1/2] debug_ll: use const char* for PUTS_LL Jean-Christophe PLAGNIOL-VILLARD
  2012-10-28  9:15 ` [PATCH 2/2] console: display Switch to console [csxx] when switching from debug_ll to real console Jean-Christophe PLAGNIOL-VILLARD
@ 2012-10-29  7:39 ` Sascha Hauer
  1 sibling, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2012-10-29  7:39 UTC (permalink / raw)
  To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox

On Sun, Oct 28, 2012 at 10:15:09AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Applied, thanks

Sascha

> ---
>  include/debug_ll.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/debug_ll.h b/include/debug_ll.h
> index a8bac27..c744573 100644
> --- a/include/debug_ll.h
> +++ b/include/debug_ll.h
> @@ -30,7 +30,7 @@
>  			     ch += (ch >= 10) ? 'a' - 10 : '0';\
>  			     PUTC_LL (ch); }})
>  
> -static __inline__ void PUTS_LL(char * str)
> +static __inline__ void PUTS_LL(const char * str)
>  {
>  	while (*str) {
>  		if (*str == '\n') {
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] console: display Switch to console [csxx] when switching from debug_ll to real console
  2012-10-28  9:15 ` [PATCH 2/2] console: display Switch to console [csxx] when switching from debug_ll to real console Jean-Christophe PLAGNIOL-VILLARD
@ 2012-10-29 20:55   ` Sascha Hauer
  2012-10-30  8:44     ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 1 reply; 6+ messages in thread
From: Sascha Hauer @ 2012-10-29 20:55 UTC (permalink / raw)
  To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox

On Sun, Oct 28, 2012 at 10:15:10AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  common/console.c |    3 +++
>  1 file changed, 3 insertions(+)

Dropped this one as it breaks most defconfigs with:

common/console.c: In function 'console_std_set':
common/console.c:90:3: warning: implicit declaration of function 'PUTS_LL' [-Wimplicit-function-declaration]
common/built-in.o: In function `console_std_set':
bootargs.c:(.text.console_std_set+0xf8): undefined reference to `PUTS_LL'
bootargs.c:(.text.console_std_set+0x104): undefined reference to `PUTS_LL'
bootargs.c:(.text.console_std_set+0x10c): undefined reference to `PUTS_LL'

Sascha

> 
> diff --git a/common/console.c b/common/console.c
> index 2e8c973..fdd5f42 100644
> --- a/common/console.c
> +++ b/common/console.c
> @@ -88,6 +88,9 @@ static int console_std_set(struct device_d *dev, struct param_d *param,
>  	if (initialized < CONSOLE_INIT_FULL) {
>  		char ch;
>  		initialized = CONSOLE_INIT_FULL;
> +		PUTS_LL("Switch to console [");
> +		PUTS_LL(dev_name(dev));
> +		PUTS_LL("]\n");
>  		barebox_banner();
>  		while (kfifo_getc(console_output_fifo, &ch) == 0)
>  			console_putc(CONSOLE_STDOUT, ch);
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] console: display Switch to console [csxx] when switching from debug_ll to real console
  2012-10-29 20:55   ` Sascha Hauer
@ 2012-10-30  8:44     ` Jean-Christophe PLAGNIOL-VILLARD
  2012-10-30  9:26       ` Sascha Hauer
  0 siblings, 1 reply; 6+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-30  8:44 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

On 21:55 Mon 29 Oct     , Sascha Hauer wrote:
> On Sun, Oct 28, 2012 at 10:15:10AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  common/console.c |    3 +++
> >  1 file changed, 3 insertions(+)
> 
> Dropped this one as it breaks most defconfigs with:
> 
> common/console.c: In function 'console_std_set':
> common/console.c:90:3: warning: implicit declaration of function 'PUTS_LL' [-Wimplicit-function-declaration]
> common/built-in.o: In function `console_std_set':
> bootargs.c:(.text.console_std_set+0xf8): undefined reference to `PUTS_LL'
> bootargs.c:(.text.console_std_set+0x104): undefined reference to `PUTS_LL'
> bootargs.c:(.text.console_std_set+0x10c): undefined reference to `PUTS_LL'
I try here on next no break

PUTS_LL is not defined if DEBUG_LL is not enabled

did you put in over the previous patch I send for the debug_ll and console

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] console: display Switch to console [csxx] when switching from debug_ll to real console
  2012-10-30  8:44     ` Jean-Christophe PLAGNIOL-VILLARD
@ 2012-10-30  9:26       ` Sascha Hauer
  0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2012-10-30  9:26 UTC (permalink / raw)
  To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox

On Tue, Oct 30, 2012 at 09:44:23AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 21:55 Mon 29 Oct     , Sascha Hauer wrote:
> > On Sun, Oct 28, 2012 at 10:15:10AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > ---
> > >  common/console.c |    3 +++
> > >  1 file changed, 3 insertions(+)
> > 
> > Dropped this one as it breaks most defconfigs with:
> > 
> > common/console.c: In function 'console_std_set':
> > common/console.c:90:3: warning: implicit declaration of function 'PUTS_LL' [-Wimplicit-function-declaration]
> > common/built-in.o: In function `console_std_set':
> > bootargs.c:(.text.console_std_set+0xf8): undefined reference to `PUTS_LL'
> > bootargs.c:(.text.console_std_set+0x104): undefined reference to `PUTS_LL'
> > bootargs.c:(.text.console_std_set+0x10c): undefined reference to `PUTS_LL'
> I try here on next no break
> 
> PUTS_LL is not defined if DEBUG_LL is not enabled
> 
> did you put in over the previous patch I send for the debug_ll and console

Ok, that was probably it. Reordered and compile testing again.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-30  9:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-28  9:15 [PATCH 1/2] debug_ll: use const char* for PUTS_LL Jean-Christophe PLAGNIOL-VILLARD
2012-10-28  9:15 ` [PATCH 2/2] console: display Switch to console [csxx] when switching from debug_ll to real console Jean-Christophe PLAGNIOL-VILLARD
2012-10-29 20:55   ` Sascha Hauer
2012-10-30  8:44     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-30  9:26       ` Sascha Hauer
2012-10-29  7:39 ` [PATCH 1/2] debug_ll: use const char* for PUTS_LL Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox