From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/2] Y-Modem implementation change
Date: Thu, 1 Nov 2012 18:50:49 +0100 [thread overview]
Message-ID: <20121101175049.GK29599@game.jcrosoft.org> (raw)
In-Reply-To: <1351791438-29967-1-git-send-email-robert.jarzmik@free.fr>
On 18:37 Thu 01 Nov , Robert Jarzmik wrote:
> Hi everyone,
>
> This patchset aims at changing the Y-Modem protocol implementation.
> You have already seen the RFC version, this is the next version, which :
> - provides a much more tested version
> - is ready for review
>
> The following comments have been taken into account :
> - Antony: testing on a serial line
> - Sascha: split between protocol and commands
> - Jean-Christophe: kermit protocol change
>
> So before doing the real review, could I ask of you :
> - Antony: could you redo your test over a serial line by applying only
> the first patch so that you can compare loady and loady2 ?
> Don't use "loady2 -g", as Y-Modem/G protocol requires a
> lossless line (USB), and a serial line cannot guarantee it.
> - Sascha: does the split command/protocol suit you ?
> - Jean-Christophe: I left the loadb implementation as it is. The goal
> of the patch is to change X-Modem and Y-Modem(G)
> implementation, not kermit. Could you test that I
> have not created a regression of loadb ?
I'll prefer to have a new command named xyz so we have no confusion between
loadb and the new one
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-11-01 17:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 17:37 Robert Jarzmik
2012-11-01 17:37 ` [PATCH 1/2] commands: change Y-Modem implementation Robert Jarzmik
2012-11-01 17:37 ` [PATCH 2/2] commands: remove old " Robert Jarzmik
2012-11-01 17:50 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-11-01 18:47 ` [PATCH 0/2] Y-Modem implementation change Antony Pavlov
2012-11-01 19:19 ` Antony Pavlov
2012-11-01 19:57 ` Robert Jarzmik
2012-11-01 19:33 ` Sascha Hauer
2012-11-04 17:55 ` [PATCH v2 1/2] commands: change Y-Modem implementation Robert Jarzmik
2012-11-04 17:55 ` [PATCH v2 2/2] commands: remove old " Robert Jarzmik
2012-11-04 18:36 ` [PATCH v2 1/2] commands: change " Jean-Christophe PLAGNIOL-VILLARD
2012-11-05 18:07 ` Robert Jarzmik
2012-11-05 18:25 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-05 18:49 ` Robert Jarzmik
2012-11-05 19:49 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-05 21:31 ` Robert Jarzmik
2012-11-06 7:34 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-06 20:50 ` Robert Jarzmik
2012-11-07 8:22 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101175049.GK29599@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox