From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3 1/3] ARM: Add CLPS711X architecture
Date: Fri, 2 Nov 2012 09:21:13 +0100 [thread overview]
Message-ID: <20121102082113.GC1641@pengutronix.de> (raw)
In-Reply-To: <20121102102419.52e6cc0269ae07ef1b3ff26d@mail.ru>
On Fri, Nov 02, 2012 at 10:24:19AM +0400, Alexander Shiyan wrote:
> On Thu, 1 Nov 2012 08:32:51 +0100
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> > On Thu, Nov 01, 2012 at 09:20:38AM +0400, Alexander Shiyan wrote:
> > > On Wed, 31 Oct 2012 22:36:08 +0100
> > > Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > >
> > > ...
> > > > > +
> > > > > + asm("mov pc, #0");
> > > >
> > > > Or is it because you do not have a real reset function and have to jump
> > > > through zero instead? Still common_reset() shouldn't be necessary. What
> > > Yes.
> > > > you may have to do here is to make sure the MMU is disabled and caches
> > > > are flushed.
> > > Yes. This call was be added for do it.
> > > I may replace entrie function by calling start(). Is it a better way()?
> >
> > arch_shutdown() should do it.
> Well, if there are no more comments for this series, I will create a v4 with
> one more forgotten fix for serial driver (IS_ERR clock check).
Fine, thanks. This should be the final one.
Two last things:
You should add pbl-y += lowlevel.o to your board Makefile. This allows
it to compile barebox as a compressed image.
You shouldn't have to overwrite env/bin/mtdparts-add. Instead this
should be called from env/init/mtdparts*
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-11-02 8:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 16:08 Alexander Shiyan
2012-10-30 16:08 ` [PATCH v3 2/3] ARM: clps711x: Add serial driver Alexander Shiyan
2012-10-30 16:08 ` [PATCH v3 3/3] ARM: clps711x: Add generic board support (CLEP7212) Alexander Shiyan
2012-10-31 21:36 ` [PATCH v3 1/3] ARM: Add CLPS711X architecture Sascha Hauer
2012-11-01 5:20 ` Alexander Shiyan
2012-11-01 7:32 ` Sascha Hauer
2012-11-02 6:24 ` Alexander Shiyan
2012-11-02 8:21 ` Sascha Hauer [this message]
2012-11-02 8:44 ` Alexander Shiyan
2012-11-02 8:54 ` Sascha Hauer
2012-11-02 9:06 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102082113.GC1641@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox