mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] mx53 loco: enable smsc phy driver
Date: Thu, 15 Nov 2012 14:40:19 +0100	[thread overview]
Message-ID: <20121115134019.GE10369@pengutronix.de> (raw)
In-Reply-To: <1352980562-25383-1-git-send-email-plagnioj@jcrosoft.com>

On Thu, Nov 15, 2012 at 12:56:02PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  arch/arm/configs/freescale_mx53_loco_defconfig |    1 +
>  1 file changed, 1 insertion(+)

We're getting closer \o/

With this the LOCO correctly waits for a link, unfortunately during
board init time. This is due to:

commit 3a17af33c01fd066ab3939c8218037c87ba26eed
Author: Sascha Hauer <s.hauer@pengutronix.de>
Date:   Fri Oct 26 16:16:54 2012 +0200

    net fec: connect phy at probe time
    
    Several i.MX boards (all i.MX6 boards) need to do some adjustments
    to phy registers. If barebox itself does not use network, networking
    won't work in the kernel if the kernel does not have the fixups. Connect
    the phy at probe time so that these tweaks are done during probe so that
    the kernel works without phy register tweaks. Also this has the effect
    that the phy device is present and introspectable without doing fake
    network transfers beforehand.

We could revert it which fixes things for the LOCO, but then we also
lose the phy fixups which this commit intentionally pushed to probe
time.

It would be nice to separate phy registration from actually waiting for
a link. I find it rather inconvenient anyway that the phy device pops
up during the first network transfer.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-11-15 13:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 11:56 Jean-Christophe PLAGNIOL-VILLARD
2012-11-15 13:40 ` Sascha Hauer [this message]
2012-11-15 13:48   ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-15 14:11     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121115134019.GE10369@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox