From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 19.mo5.mail-out.ovh.net ([46.105.35.78] helo=mo5.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TYzpq-0007SI-07 for barebox@lists.infradead.org; Thu, 15 Nov 2012 13:50:27 +0000 Received: from mail629.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo5.mail-out.ovh.net (Postfix) with SMTP id ACE83FFB855 for ; Thu, 15 Nov 2012 14:58:04 +0100 (CET) Date: Thu, 15 Nov 2012 14:48:23 +0100 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20121115134823.GH31820@game.jcrosoft.org> References: <1352980562-25383-1-git-send-email-plagnioj@jcrosoft.com> <20121115134019.GE10369@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20121115134019.GE10369@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/1] mx53 loco: enable smsc phy driver To: Sascha Hauer Cc: barebox@lists.infradead.org On 14:40 Thu 15 Nov , Sascha Hauer wrote: > On Thu, Nov 15, 2012 at 12:56:02PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > --- > > arch/arm/configs/freescale_mx53_loco_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > We're getting closer \o/ > > With this the LOCO correctly waits for a link, unfortunately during > board init time. This is due to: > > commit 3a17af33c01fd066ab3939c8218037c87ba26eed > Author: Sascha Hauer > Date: Fri Oct 26 16:16:54 2012 +0200 > > net fec: connect phy at probe time > > Several i.MX boards (all i.MX6 boards) need to do some adjustments > to phy registers. If barebox itself does not use network, networking > won't work in the kernel if the kernel does not have the fixups. Connect > the phy at probe time so that these tweaks are done during probe so that > the kernel works without phy register tweaks. Also this has the effect > that the phy device is present and introspectable without doing fake > network transfers beforehand. > > We could revert it which fixes things for the LOCO, but then we also > lose the phy fixups which this commit intentionally pushed to probe > time. > > It would be nice to separate phy registration from actually waiting for > a link. I find it rather inconvenient anyway that the phy device pops > up during the first network transfer. so we need to introduce a phy_start that start the check of the link but I think the kernel need to its own fixup and do not relay on the booloader to do it for him Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox