From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TaMmF-0003Ux-T2 for barebox@lists.infradead.org; Mon, 19 Nov 2012 08:32:24 +0000 Date: Mon, 19 Nov 2012 09:32:21 +0100 From: Sascha Hauer Message-ID: <20121119083221.GA10369@pengutronix.de> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: shouldn't asm-generic/barebox.lds.h be arch-independent? To: "Robert P. J. Day" Cc: "U-Boot Version 2 (barebox)" On Sun, Nov 18, 2012 at 01:31:06PM -0500, Robert P. J. Day wrote: > > there is one more oddity(?) with the way the linker "lds" files are > set up. if i read this correctly (and i could be wrong), here's > arch/x86/lib/barebox.lds.S: > > #undef i386 > #include > > which gets us to that included file, which contains: > > #if defined CONFIG_ARCH_IMX25 || \ > defined CONFIG_ARCH_IMX35 || \ > defined CONFIG_ARCH_IMX51 || \ > defined CONFIG_ARCH_IMX53 || \ > defined CONFIG_ARCH_IMX6 || \ > defined CONFIG_X86 || \ <-- that will be true, correct? > defined CONFIG_ARCH_EP93XX > #include > #endif Instead of having this the users should include asm/barebox.lds.h which then in turn includes asm-generic/barebox.lds.h. > > which finally takes us to > arch/x86/mach-i386/include/mach/barebox.lds.h, which is nothing more > than a collection of macro definitions. there's no "pre-image" > content to be incorporated into the final image -- it's just > preprocessor content. so why isn't all that simply at the beginning > of the main x86 barebox.lds.S file? I don't know. It should probably be moved there. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox