* [PATCH] arm lib: Remove redundant boot usage info from boot[uz].c
@ 2012-11-18 13:39 Robert P. J. Day
2012-11-19 9:14 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2012-11-18 13:39 UTC (permalink / raw)
To: U-Boot Version 2 (barebox)
There is no need to add the command name to the "usage" info when
defining a command.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
fairly sure the command name is superfluous in the usage string,
yes?
diff --git a/arch/arm/lib/bootu.c b/arch/arm/lib/bootu.c
index 0d155cb..75e0de3 100644
--- a/arch/arm/lib/bootu.c
+++ b/arch/arm/lib/bootu.c
@@ -36,7 +36,7 @@ static const __maybe_unused char cmd_bootu_help[] =
BAREBOX_CMD_START(bootu)
.cmd = do_bootu,
- .usage = "bootu - start a raw linux image",
+ .usage = "start a raw linux image",
BAREBOX_CMD_HELP(cmd_bootu_help)
BAREBOX_CMD_END
diff --git a/arch/arm/lib/bootz.c b/arch/arm/lib/bootz.c
index f069127..9f5b3b4 100644
--- a/arch/arm/lib/bootz.c
+++ b/arch/arm/lib/bootz.c
@@ -133,7 +133,7 @@ static const __maybe_unused char cmd_bootz_help[] =
BAREBOX_CMD_START(bootz)
.cmd = do_bootz,
- .usage = "bootz - start a zImage",
+ .usage = "start a zImage",
BAREBOX_CMD_HELP(cmd_bootz_help)
BAREBOX_CMD_END
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arm lib: Remove redundant boot usage info from boot[uz].c
2012-11-18 13:39 [PATCH] arm lib: Remove redundant boot usage info from boot[uz].c Robert P. J. Day
@ 2012-11-19 9:14 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2012-11-19 9:14 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: U-Boot Version 2 (barebox)
On Sun, Nov 18, 2012 at 08:39:51AM -0500, Robert P. J. Day wrote:
>
> There is no need to add the command name to the "usage" info when
> defining a command.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Applied, thanks
Sascha
>
> ---
>
> fairly sure the command name is superfluous in the usage string,
> yes?
>
> diff --git a/arch/arm/lib/bootu.c b/arch/arm/lib/bootu.c
> index 0d155cb..75e0de3 100644
> --- a/arch/arm/lib/bootu.c
> +++ b/arch/arm/lib/bootu.c
> @@ -36,7 +36,7 @@ static const __maybe_unused char cmd_bootu_help[] =
>
> BAREBOX_CMD_START(bootu)
> .cmd = do_bootu,
> - .usage = "bootu - start a raw linux image",
> + .usage = "start a raw linux image",
> BAREBOX_CMD_HELP(cmd_bootu_help)
> BAREBOX_CMD_END
>
> diff --git a/arch/arm/lib/bootz.c b/arch/arm/lib/bootz.c
> index f069127..9f5b3b4 100644
> --- a/arch/arm/lib/bootz.c
> +++ b/arch/arm/lib/bootz.c
> @@ -133,7 +133,7 @@ static const __maybe_unused char cmd_bootz_help[] =
>
> BAREBOX_CMD_START(bootz)
> .cmd = do_bootz,
> - .usage = "bootz - start a zImage",
> + .usage = "start a zImage",
> BAREBOX_CMD_HELP(cmd_bootz_help)
> BAREBOX_CMD_END
>
>
> --
>
> ========================================================================
> Robert P. J. Day Ottawa, Ontario, CANADA
> http://crashcourse.ca
>
> Twitter: http://twitter.com/rpjday
> LinkedIn: http://ca.linkedin.com/in/rpjday
> ========================================================================
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-19 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-18 13:39 [PATCH] arm lib: Remove redundant boot usage info from boot[uz].c Robert P. J. Day
2012-11-19 9:14 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox