From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/5] mci: Allow to specify device name
Date: Fri, 30 Nov 2012 05:57:32 +0100 [thread overview]
Message-ID: <20121130045732.GA8327@game.jcrosoft.org> (raw)
In-Reply-To: <1354215748-25394-3-git-send-email-s.hauer@pengutronix.de>
On 20:02 Thu 29 Nov , Sascha Hauer wrote:
> When multiple MMC/SD cards are present in the system we often
> have to have persistent names to identify them during runtime.
> This patch allows to overwrite the devicename which is used.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/mci/mci-core.c | 10 +++++++---
> include/mci.h | 1 +
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index 942d126..6e556a8 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -1397,9 +1397,13 @@ static int mci_card_probe(struct mci *mci)
> mci->blk.dev = mci->mci_dev;
> mci->blk.ops = &mci_ops;
>
> - disknum = cdev_find_free_index("disk");
> + if (host->devname) {
> + mci->blk.cdev.name = strdup(host->devname);
can you use is a based name not the name
> + } else {
> + disknum = cdev_find_free_index("disk");
> + mci->blk.cdev.name = asprintf("disk%d", disknum);
> + }
>
> - mci->blk.cdev.name = asprintf("disk%d", disknum);
> mci->blk.blockbits = SECTOR_SHIFT;
> mci->blk.num_blocks = mci_calc_blk_cnt(mci->capacity, mci->blk.blockbits);
>
> @@ -1409,7 +1413,7 @@ static int mci_card_probe(struct mci *mci)
> goto on_error;
> }
>
> - dev_info(mci->mci_dev, "registered disk%d\n", disknum);
> + dev_info(mci->mci_dev, "registered %s\n", mci->blk.cdev.name);
>
> /* create partitions on demand */
> rc = parse_partition_table(&mci->blk);
> diff --git a/include/mci.h b/include/mci.h
> index db78b9c..0041e27 100644
> --- a/include/mci.h
> +++ b/include/mci.h
> @@ -286,6 +286,7 @@ struct mci_ios {
> /** host information */
> struct mci_host {
> struct device_d *hw_dev; /**< the host MCI hardware device */
> + char *devname; /**< the devicename for the card, defaults to disk%d */
> unsigned voltages;
> unsigned host_caps; /**< Host's interface capabilities, refer MMC_VDD_* */
> unsigned f_min; /**< host interface lower limit */
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-11-30 4:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 19:02 [PATCH 1/5] mci: Add STUFF_BITS and use it Sascha Hauer
2012-11-29 19:02 ` [PATCH 2/5] mci: Fix capacity calculation for high capacity MMC cards Sascha Hauer
2012-12-03 8:38 ` Sascha Hauer
2012-11-29 19:02 ` [PATCH 3/5] mci: Allow to specify device name Sascha Hauer
2012-11-30 4:57 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-11-30 8:06 ` Sascha Hauer
2012-11-30 10:10 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-03 8:33 ` Sascha Hauer
2012-11-29 19:02 ` [PATCH 4/5] mci i.MX esdhc: Allow to specify devicename from platformdata Sascha Hauer
2012-11-29 19:02 ` [PATCH 5/5] mci i.MX esdhc: turn error message into debug message Sascha Hauer
2012-12-05 19:02 ` [PATCH 1/5] mci: Add STUFF_BITS and use it Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130045732.GA8327@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox