From: Sascha Hauer <s.hauer@pengutronix.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mxs: tx28: fix NAND usage
Date: Wed, 5 Dec 2012 19:33:28 +0100 [thread overview]
Message-ID: <20121205183328.GJ10369@pengutronix.de> (raw)
In-Reply-To: <1354718562-24328-1-git-send-email-w.sang@pengutronix.de>
On Wed, Dec 05, 2012 at 03:42:42PM +0100, Wolfram Sang wrote:
> Pinmuxing was wrong and no GPMI device was created.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Applied, thanks
Sascha
> ---
> arch/arm/boards/karo-tx28/tx28.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boards/karo-tx28/tx28.c b/arch/arm/boards/karo-tx28/tx28.c
> index a62cb82..6e8da15 100644
> --- a/arch/arm/boards/karo-tx28/tx28.c
> +++ b/arch/arm/boards/karo-tx28/tx28.c
> @@ -35,11 +35,12 @@ static const uint32_t tx28_pad_setup[] = {
> GPMI_D6 | VE_3_3V | PULLUP(1),
> GPMI_D7 | VE_3_3V | PULLUP(1),
> GPMI_READY0 | VE_3_3V | PULLUP(0), /* external PU */
> + GPMI_CE0N | VE_3_3V | PULLUP(1),
> GPMI_RDN | VE_3_3V | PULLUP(1),
> GPMI_WRN | VE_3_3V | BITKEEPER(1),
> GPMI_ALE | VE_3_3V | PULLUP(1),
> GPMI_CLE | VE_3_3V | PULLUP(1),
> - GPMI_RESETN_GPIO | VE_3_3V | GPIO_IN, /* act as WP, external PU */
> + GPMI_RESETN | VE_3_3V | PULLUP(0), /* external PU */
>
> /* Network interface */
>
> @@ -91,6 +92,9 @@ static int tx28_devices_init(void)
>
> base_board_init();
>
> + add_generic_device("mxs_nand", 0, NULL, MXS_GPMI_BASE, 0x2000,
> + IORESOURCE_MEM, NULL);
> +
> return 0;
> }
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-12-05 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 14:42 Wolfram Sang
2012-12-05 18:33 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205183328.GJ10369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox