From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC 0/2] clk: pass the 'flags' parameter to clk_fixed()
Date: Thu, 6 Dec 2012 14:44:13 +0100 [thread overview]
Message-ID: <20121206134413.GX10369@pengutronix.de> (raw)
In-Reply-To: <1354782336-16239-1-git-send-email-antonynpavlov@gmail.com>
Hi Antony,
On Thu, Dec 06, 2012 at 12:25:34PM +0400, Antony Pavlov wrote:
> The 'flags' parameter make possible creation
> of a 'CLK_ALWAYS_ENABLED' clock without code overhead.
>
> So it is possible to create clock this way
> clk_fixed("main_clock", 24000000, 0);
> or that way
> clk_fixed("main_clock", 24000000, CLK_ALWAYS_ENABLED);
>
> I can't check my clk_fixed-related changes for ARM-based
> boards, so please consider, do we need CLK_ALWAYS_ENABLED
> in the patch '[RFC 2/2]' or we need '0'.
Nice move to be able to pass the flags to clk_fixed. For this special
clock and flag we won't need it though: The fixed clock by definition
always is enabled. We should rather set this flag unconditionally for
them.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-12-06 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 8:25 Antony Pavlov
2012-12-06 8:25 ` [RFC 1/2] " Antony Pavlov
2012-12-06 8:25 ` [RFC 2/2] ARM: pass the 'flags'=0 " Antony Pavlov
2012-12-06 13:44 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206134413.GX10369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox