From: 张忠山 <zzs213@126.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH] fix GENERIC_PHY match nothing
Date: Mon, 10 Dec 2012 09:52:25 +0800 [thread overview]
Message-ID: <20121210015225.GC2605@greatfirst.com> (raw)
In-Reply-To: <20121208123830.GM24458@pengutronix.de>
In message <20121208123830.GM24458@pengutronix.de> Sascha Hauer wrote:
> On Sat, Dec 08, 2012 at 12:15:03PM +0100, Sascha Hauer wrote:
> > On Sat, Dec 08, 2012 at 09:58:52AM +0800, 张忠山 wrote:
> > > According the match logic in function mdio_bus_match
> > > generic phy driver matchs nothing.
> >
> > This is done on purpose. The generic phy driver is probed manually
> > when no other phy matches, see:
> >
> > > static int phy_register_device(struct phy_device* dev)
> > > {
> > > int ret;
> > >
> > > ret = register_device(&dev->dev);
> > > if (ret)
> > > return ret;
> >
> > register device...
> >
> > >
> > > if (dev->dev.driver)
> > > return 0;
> >
> > ... we have a driver specific to this phy, -> return
> >
> > >
> > > dev->dev.driver = &genphy_driver.drv;
> > > return device_probe(&dev->dev);
> >
> > No driver, use generic phy driver.
> >
> > >}
> >
> > The problem this solves (and that you reintroduce with this patch) is
> > that if the phy driver matches every device, a more specific phy driver
> > will not be used if the generic driver is registered first.
>
> Now I understand what you mean.
>
Sorry for not mention the source code version
--
Best Regards,
zzs
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-12-10 2:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 1:58 张忠山
2012-12-08 11:15 ` Sascha Hauer
2012-12-08 12:38 ` Sascha Hauer
2012-12-10 1:52 ` 张忠山 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210015225.GC2605@greatfirst.com \
--to=zzs213@126.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox